[Bug c++/94477] New: ICE in tsubst_expr, at cp/pt.c:18181

[Bug c++/94477] New: ICE in tsubst_expr, at cp/pt.c:18181

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

            Bug ID: 94477
           Summary: ICE in tsubst_expr, at cp/pt.c:18181
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code, openmp
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

g++-10.0.1-alpha20200329 snapshot (g:60c254b279e8e8443b8ad26cc46b9e4084cff66c)
ICEs when compiling the following testcase, extracted from
test/OpenMP/parallel_master_taskloop_collapse_messages.cpp from the clang
10.0.0 test suite, w/ -fopenmp:

void
j3 ();

template <int>
void
xm ()
{
  #pragma omp parallel master
  j3 ();
}

void
s3 ()
{
   xm<0> ();
}

% g++-10.0.1 -fopenmp -c qnx2epwv.cpp
qnx2epwv.cpp: In instantiation of 'void xm() [with int <anonymous> = 0]':
qnx2epwv.cpp:15:11:   required from here
qnx2epwv.cpp:8:11: internal compiler error: in tsubst_expr, at cp/pt.c:18181
    8 |   #pragma omp parallel master
      |           ^~~
0x659d49 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200329/work/gcc-10-20200329/gcc/cp/pt.c:18181
0x9eb63a tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200329/work/gcc-10-20200329/gcc/cp/pt.c:17985
0x9e97f6 instantiate_decl(tree_node*, bool, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200329/work/gcc-10-20200329/gcc/cp/pt.c:25507
0xa1a4ab instantiate_pending_templates(int)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200329/work/gcc-10-20200329/gcc/cp/pt.c:25623
0x91fbd3 c_parse_final_cleanups()
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200329/work/gcc-10-20200329/gcc/cp/decl2.c:4874

[Bug c++/94477] ICE in tsubst_expr, at cp/pt.c:18181

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-04-03
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 48192
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48192&action=edit
gcc10-pr94477.patch

Untested fix.

[Bug c++/94477] ICE in tsubst_expr, at cp/pt.c:18181

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0c809f727cd2a6c70c307d9dd53d26dc84bf292a

commit r10-7547-g0c809f727cd2a6c70c307d9dd53d26dc84bf292a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Apr 4 00:35:41 2020 +0200

    openmp: Fix ICE on #pragma omp parallel master in template [PR94477]

    The following testcase ICEs, because for parallel combined with some
    other construct we initialize the omp_parallel_combined_clauses pointer
    and expect the construct combined with it to clear it after it no longer
    needs it, but OMP_MASTER didn't do that.

    2020-04-04  Jakub Jelinek  <jakub@redhat.com>

            PR c++/94477
            * pt.c (tsubst_expr) <case OMP_MASTER>: Clear
            omp_parallel_combined_clauses.

            * g++.dg/gomp/pr94477.C: New test.

[Bug c++/94477] ICE in tsubst_expr, at cp/pt.c:18181

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug c++/94477] ICE in tsubst_expr, at cp/pt.c:18181

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d1371dbe12214895cda0b13bfc6ff0ed9cbce15d

commit r9-8478-gd1371dbe12214895cda0b13bfc6ff0ed9cbce15d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Apr 4 00:35:41 2020 +0200

    openmp: Fix ICE on #pragma omp parallel master in template [PR94477]

    The following testcase ICEs, because for parallel combined with some
    other construct we initialize the omp_parallel_combined_clauses pointer
    and expect the construct combined with it to clear it after it no longer
    needs it, but OMP_MASTER didn't do that.

    2020-04-04  Jakub Jelinek  <jakub@redhat.com>

            PR c++/94477
            * pt.c (tsubst_expr) <case OMP_MASTER>: Clear
            omp_parallel_combined_clauses.

            * g++.dg/gomp/pr94477.C: New test.

[Bug c++/94477] ICE in tsubst_expr, at cp/pt.c:18181

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

--- Comment #5 from Arseny Solokha <asolokha at gmx dot com> ---
Is there some further work pending, or can this PR be closed?

[Bug c++/94477] ICE in tsubst_expr, at cp/pt.c:18181

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94477

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 doesn't support parallel master, so this is now fixed everywhere.