public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/94488] [AArch64] ICE on right shift of V2DImode by DImode shift Date: Tue, 07 Apr 2020 08:02:41 +0000 [thread overview] Message-ID: <bug-94488-4-f4hxuZ93n5@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94488-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94488 --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:7a6588fe65432c0f1a8b5fdefba81700ebf88711 commit r10-7584-g7a6588fe65432c0f1a8b5fdefba81700ebf88711 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Apr 7 10:01:16 2020 +0200 aarch64: Fix {ash[lr],lshr}<mode>3 expanders [PR94488] The following testcase ICEs on aarch64 apparently since the introduction of the aarch64 port. The reason is that the {ashl,ashr,lshr}<mode>3 expanders completely unnecessarily FAIL; if operands[2] is something other than a CONST_INT or REG or MEM and the middle-end code can't cope with the pattern giving up in these cases. All the expanders use general_operand predicate for the shift amount operand, but then have just a special case for CONST_INT (if in-bound, emit an immediate shift, otherwise force into REG), or MEM (force into REG), or REG (that is the case it handles). In the testcase, operands[2] is a lowpart SUBREG of a REG, which is valid general_operand. I don't see any reason what is magic about MEMs that it should be forced into REG and others like SUBREGs that it shouldn't, there isn't even a reason to check for !REG_P because force_reg will do nothing if the operand is already a REG, and otherwise can handle general_operand just fine. 2020-04-07 Jakub Jelinek <jakub@redhat.com> PR target/94488 * config/aarch64/aarch64-simd.md (ashl<mode>3, lshr<mode>3, ashr<mode>3): Force operands[2] into reg whenever it is not CONST_INT. Assume it is a REG after that instead of testing it and doing FAIL otherwise. Formatting fix. * gcc.c-torture/compile/pr94488.c: New test.
next prev parent reply other threads:[~2020-04-07 8:02 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-04 17:53 [Bug rtl-optimization/94488] New: [AArch64] ICE from OpenMP SIMD right shift of uint64_t evan@coeus-group.com 2020-04-04 18:18 ` [Bug tree-optimization/94488] " pinskia at gcc dot gnu.org 2020-04-04 19:27 ` jakub at gcc dot gnu.org 2020-04-06 2:11 ` [Bug tree-optimization/94488] [AArch64] ICE on right shift of V2DImode by DImode shift evan@coeus-group.com 2020-04-06 6:40 ` [Bug target/94488] " jakub at gcc dot gnu.org 2020-04-07 8:02 ` cvs-commit at gcc dot gnu.org [this message] 2020-04-07 17:04 ` cvs-commit at gcc dot gnu.org 2020-04-07 19:04 ` cvs-commit at gcc dot gnu.org 2020-09-17 17:28 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94488-4-f4hxuZ93n5@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).