[Bug c++/94512] New: [10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[Bug c++/94512] New: [10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

            Bug ID: 94512
           Summary: [10 Regression] ICE in tsubst_expr, at cp/pt.c:18210
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Keywords: error-recovery, ice-on-invalid-code, openmp
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

g++-10.0.1-alpha20200405 snapshot (g:2a1a0c8c0db0aae50a2cebce59bd64334cd6ba2a)
ICEs when compiling the following testcase, extracted from
test/OpenMP/parallel_master_taskloop_simd_collapse_messages.cpp from the clang
10.0.0 test suite, w/ -fopenmp:

void
ow ();

template <int>
void
ho ()
{
#pragma omp parallel master taskloop
  ow ();
}

void
th ()
{
  ho<0> ();
}

% g++-10.0.1 -fopenmp -c e4oc5ifw.cpp
e4oc5ifw.cpp: In function 'void ho()':
e4oc5ifw.cpp:9:3: error: for statement expected before 'ow'
    9 |   ow ();
      |   ^~
e4oc5ifw.cpp: In instantiation of 'void ho() [with int <anonymous> = 0]':
e4oc5ifw.cpp:15:10:   required from here
e4oc5ifw.cpp:9:3: internal compiler error: in tsubst_expr, at cp/pt.c:18210
0x659911 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200405/work/gcc-10-20200405/gcc/cp/pt.c:18210
0x9ed1e2 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200405/work/gcc-10-20200405/gcc/cp/pt.c:17696
0x9ed997 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200405/work/gcc-10-20200405/gcc/cp/pt.c:18014
0x9eaad6 instantiate_decl(tree_node*, bool, bool)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200405/work/gcc-10-20200405/gcc/cp/pt.c:25538
0xa1b7eb instantiate_pending_templates(int)
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200405/work/gcc-10-20200405/gcc/cp/pt.c:25654
0x920d33 c_parse_final_cleanups()
       
/var/tmp/portage/sys-devel/gcc-10.0.1_alpha20200405/work/gcc-10-20200405/gcc/cp/decl2.c:4874

[Bug c++/94512] [10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |10.0

[Bug c++/94512] [9/10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
   Last reconfirmed|                            |2020-04-07
             Status|UNCONFIRMED                 |ASSIGNED
   Target Milestone|10.0                        |9.4
            Summary|[10 Regression] ICE in      |[9/10 Regression] ICE in
                   |tsubst_expr, at             |tsubst_expr, at
                   |cp/pt.c:18210               |cp/pt.c:18210
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
ICEs since r9-3941-g28567c40e2c7c88e424283e8a1a6ff8cb7ba440c

[Bug c++/94512] [9/10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 48226
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48226&action=edit
gcc10-pr94512.patch

Untested fix.

[Bug c++/94512] [9/10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4df50a059fbd4d4a1cb067bd43caccdfca0327a8

commit r10-7585-g4df50a059fbd4d4a1cb067bd43caccdfca0327a8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 7 14:30:53 2020 +0200

    openmp: Fix parallel master error recovery [PR94512]

    We need to set OMP_PARALLEL_COMBINED only if the parsing of omp_master
    succeeded, because otherwise there is no nested master construct in the
    parallel.

    2020-04-07  Jakub Jelinek  <jakub@redhat.com>

            PR c++/94512
            * c-parser.c (c_parser_omp_parallel): Set OMP_PARALLEL_COMBINED
            if c_parser_omp_master succeeded.

            * parser.c (cp_parser_omp_parallel): Set OMP_PARALLEL_COMBINED
            if cp_parser_omp_master succeeded.

            * g++.dg/gomp/pr94512.C: New test.

[Bug c++/94512] [9/10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0490cb0e6113783173f1b986211267fd03415346

commit r9-8481-g0490cb0e6113783173f1b986211267fd03415346
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 7 14:30:53 2020 +0200

    openmp: Fix parallel master error recovery [PR94512]

    We need to set OMP_PARALLEL_COMBINED only if the parsing of omp_master
    succeeded, because otherwise there is no nested master construct in the
    parallel.

    2020-04-07  Jakub Jelinek  <jakub@redhat.com>

            PR c++/94512
            * c-parser.c (c_parser_omp_parallel): Set OMP_PARALLEL_COMBINED
            if c_parser_omp_master succeeded.

            * parser.c (cp_parser_omp_parallel): Set OMP_PARALLEL_COMBINED
            if cp_parser_omp_master succeeded.

            * g++.dg/gomp/pr94512.C: New test.

[Bug c++/94512] [9/10 Regression] ICE in tsubst_expr, at cp/pt.c:18210

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94512

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.