[Bug go/94513] New: [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[Bug go/94513] New: [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

            Bug ID: 94513
           Summary: [10 Regression] go buildid and cgo tools require
                    symbols in GLIBC_PRIVATE namespace
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: rguenth at gcc dot gnu.org
                CC: cmang at google dot com
  Target Milestone: ---

> readelf -s buildid | grep GLIBC_PRIVATE
    25: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND __mmap@GLIBC_PRIVATE
(3)
    32: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND
__munmap@GLIBC_PRIVATE (3)
> readelf -s cgo | grep GLIBC_PRIVATE
    60: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND __mmap@GLIBC_PRIVATE
(3)
   204: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND
__munmap@GLIBC_PRIVATE (3)

this makes them uninstallable on SUSE systems.  It also looks like a recent
regression.

[Bug go/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.0
                 CC|                            |hjl.tools at gmail dot com

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Caused by 710d54ed4e343a08d2fa0abc6b63c53dec0d9bcb

[Bug go/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
I guess the proper solution is to invoke the syscalls directly rather than
going through the libc wrappers?

[Bug libgcc/94513] [10 Regression] morestack require symbols in GLIBC_PRIVATE namespace

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Assignee|ian at airs dot com                |unassigned at gcc dot gnu.org
          Component|go                          |libgcc
             Target|                            |*-linux-gnu
           Keywords|                            |build
   Last reconfirmed|                            |2020-04-07
            Summary|[10 Regression] go buildid  |[10 Regression] morestack
                   |and cgo tools require       |require symbols in
                   |symbols in GLIBC_PRIVATE    |GLIBC_PRIVATE namespace
                   |namespace                   |
     Ever confirmed|0                           |1

[Bug go/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|build                       |
             Status|NEW                         |UNCONFIRMED
             Target|*-linux-gnu                 |
          Component|libgcc                      |go
     Ever confirmed|1                           |0
           Assignee|unassigned at gcc dot gnu.org      |ian at airs dot com
   Last reconfirmed|2020-04-07 00:00:00         |
            Summary|[10 Regression] morestack   |[10 Regression] go buildid
                   |require symbols in          |and cgo tools require
                   |GLIBC_PRIVATE namespace     |symbols in GLIBC_PRIVATE
                   |                            |namespace
      Known to work|                            |9.3.1

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
For configurability generic-morestack.c should likely use a private wrapper
for mmap and munmap used in the single place of actual allocation/deallocation
(and maybe declared always_inline) while the "probing" uses in
__morestack_load_mmap can refer back to the libc variants.

This still works "correctly" on the GCC 9 branch.

[Bug libgcc/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-04-07
             Status|UNCONFIRMED                 |NEW
           Assignee|ian at airs dot com                |unassigned at gcc dot gnu.org
          Component|go                          |libgcc
     Ever confirmed|0                           |1

[Bug libgcc/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
                 CC|                            |jakub at gcc dot gnu.org

[Bug libgcc/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Ian Lance Taylor <ian@gcc.gnu.org>:

https://gcc.gnu.org/g:50c7853216e8511971c55b51d7fe29173db4749b

commit r10-7605-g50c7853216e8511971c55b51d7fe29173db4749b
Author: Ian Lance Taylor <iant@golang.org>
Date:   Tue Apr 7 11:29:41 2020 -0700

    libgcc: use syscall rather than __mmap/__munmap

            PR libgcc/94513
            * generic-morestack.c: Give up trying to use __mmap/__munmap, use
            syscall instead.

[Bug libgcc/94513] [10 Regression] go buildid and cgo tools require symbols in GLIBC_PRIVATE namespace

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94513

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Ian Lance Taylor <ian at airs dot com> ---
At least this specific problem should be fixed now.  Perhaps there will be
other problems, but they will be different.  Sorry for the difficulties.