[Bug libstdc++/94520] New: [10 Regression] <charconv> no longer compiles in C++14

[Bug libstdc++/94520] New: [10 Regression] <charconv> no longer compiles in C++14

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94520

            Bug ID: 94520
           Summary: [10 Regression] <charconv> no longer compiles in C++14
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org
  Target Milestone: ---

This is supposed to be supported in C++14 as an extension:

#include <charconv>
int main() { }

But since r272695 it no longer works:

/home/jwakely/gcc/10/include/c++/10.0.1/charconv:71:21: error: '__or_v' was not
declared in this scope; did you mean '__or_'?
   71 |       = enable_if_t<__or_v<__is_signed_integer<_Tp>,
      |                     ^~~~~~
      |                     __or_

[Bug libstdc++/94520] [10 Regression] <charconv> no longer compiles in C++14

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94520

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |10.0
     Ever confirmed|0                           |1
      Known to work|                            |9.3.0
   Target Milestone|---                         |10.0
   Last reconfirmed|                            |2020-04-07
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED

[Bug libstdc++/94520] [10 Regression] <charconv> no longer compiles in C++14

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94520

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:c104e8f1b67a75ea82c62f1fd2aac69c09127562

commit r10-7601-gc104e8f1b67a75ea82c62f1fd2aac69c09127562
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Apr 7 17:18:21 2020 +0100

    libstdc++: Restore ability to use <charconv> in C++14 (PR 94520)

    This C++17 header is supported in C++14 as a GNU extension, but stopped
    working last year because I made it depend on an internal helper which
    is only defined for C++17 and up.

            PR libstdc++/94520
            * include/std/charconv (__integer_to_chars_result_type)
            (__integer_from_chars_result_type): Use __or_ instead of __or_v_ to
            allow use in C++14.
            * testsuite/20_util/from_chars/1.cc: Run test as C++14 and replace
            use of std::string_view with std::string.
            * testsuite/20_util/from_chars/2.cc: Likewise.
            * testsuite/20_util/to_chars/1.cc: Likewise.
            * testsuite/20_util/to_chars/2.cc: Likewise.

[Bug libstdc++/94520] [10 Regression] <charconv> no longer compiles in C++14

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94520

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed.