public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/94521] Infinite loop with decltype of function parameter of type decltype([]{}) Date: Mon, 13 Apr 2020 21:04:53 +0000 [thread overview] Message-ID: <bug-94521-4-MYUlZcr7AN@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94521-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94521 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:1dcb779916502a44b4ae67d6bf60eb59474bd78c commit r10-7705-g1dcb779916502a44b4ae67d6bf60eb59474bd78c Author: Patrick Palka <ppalka@redhat.com> Date: Mon Apr 13 16:53:41 2020 -0400 c++: Infinite diagnostic loop with decltype([]{}) [PR94521] We are hitting a recursive loop when printing the signature of a function containing a decltype([]{}) type. The loop is dump_function_decl -> dump_substitution -> dump_template_bindings -> dump_type -> dump_aggr_type -> dump_scope -> dump_function_decl and we loop because dump_template_bindings wants to print the resolved type of decltype([]{}) (i.e. just a lambda type), so it calls dump_aggr_type, which wants to print the function scope of the lambda type. But the function scope of the lambda type is the function which we're in the middle of printing. This patch breaks the loop by passing TFF_NO_FUNCTION_ARGUMENTS to dump_function_decl from dump_scope, so that we avoid recursing into dump_substitution and ultimately looping. This also means we no longer emit the "[with ...]" clause when printing a function template scope, and we instead just emit its template argument list in a more natural way, e.g. instead of foo(int, char) [with T=bool]::x we would now print foo<bool>::x which seems like an improvement on its own. The full signature of the function 'spam' in the below testcase is now void spam(decltype (<lambda>)*) [with T = int; decltype (<lambda>) = spam<int>::<lambda()>] gcc/cp/ChangeLog: PR c++/94521 * error.c (dump_scope): Pass TFF_NO_FUNCTION_ARGUMENTS to dump_function_decl when printing a function template instantiation as a scope. gcc/testsuite/ChangeLog: PR c++/94521 * g++.dg/cpp2a/lambda-uneval12.C: New test.
next prev parent reply other threads:[~2020-04-13 21:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-07 15:57 [Bug c++/94521] New: " ppalka at gcc dot gnu.org 2020-04-07 16:00 ` [Bug c++/94521] " mpolacek at gcc dot gnu.org 2020-04-09 17:34 ` ppalka at gcc dot gnu.org 2020-04-13 21:04 ` cvs-commit at gcc dot gnu.org [this message] 2020-04-13 21:05 ` ppalka at gcc dot gnu.org 2021-02-25 21:45 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94521-4-MYUlZcr7AN@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).