[Bug c++/94528] New: coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[Bug c++/94528] New: coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

            Bug ID: 94528
           Summary: coroutines: ICE building cppcoro in gimplify_expr, at
                    gimplify.c:14399
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: iains at gcc dot gnu.org
  Target Milestone: ---

Created attachment 48237
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48237&action=edit
c-reduced reproducer.

[Bug c++/94528] coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |iains at gcc dot gnu.org
   Last reconfirmed|                            |2020-04-07

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 48238
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48238&action=edit
Patch being tested

[Bug c++/94528] coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.0
           Keywords|                            |ice-on-valid-code

[Bug c++/94528] coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |euloanty at live dot com

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
*** Bug 93343 has been marked as a duplicate of this bug. ***

[Bug c++/94528] coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nathan at gcc dot gnu.org

--- Comment #3 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
The patch is ok.  For avoidance of doubt, the 'for now' comment refers to an
issue addressed in a following patch.

[Bug c++/94528] coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:0666767eb4cc864f00ba34d97b9d58f8dc650bba

commit r10-7682-g0666767eb4cc864f00ba34d97b9d58f8dc650bba
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Fri Apr 10 20:55:10 2020 +0100

    coroutines: Revise await expansions [PR94528]

    The expansions for await expressions were specific to particular
    cases, this revises it to be more generic.

    a: Revise co_await statement walkers.

    We want to process the co_awaits one statement at a time.
    We also want to be able to determine the insertion points for
    new bind scopes needed to cater for temporaries that are
    captured by reference and have lifetimes that need extension
    to the end of the full expression.  Likewise, the handling of
    captured references in the evaluation of conditions might
    result in the need to make a frame copy.

    This reorganises the statement walking code to make it easier to
    extend for these purposes.

    b: Factor reference-captured temp code.

    We want to be able to use the code that writes a new bind expr
    with vars (and their initializers) from several places, so split
    that out of the maybe_promote_captured_temps() function into a
    new replace_statement_captures ().  Update some comments.

    c: Generalize await statement expansion.

    This revises the expansion to avoid the need to expand conditionally
    on the tree type.  It resolves PR 94528.

    gcc/cp/ChangeLog:

    2020-04-10  Iain Sandoe  <iain@sandoe.co.uk>

            PR c++/94538
            * coroutines.cc (co_await_expander): Remove.
            (expand_one_await_expression): New.
            (process_one_statement): New.
            (await_statement_expander): New.
            (build_actor_fn): Revise to use per-statement expander.
            (struct susp_frame_data): Reorder and comment.
            (register_awaits): Factor code.
            (replace_statement_captures): New, factored from...
            (maybe_promote_captured_temps):.. here.
            (await_statement_walker): Revise to process per statement.
            (morph_fn_to_coro): Use revised susp_frame_data layout.

    gcc/testsuite/ChangeLog:

    2020-04-10  Iain Sandoe  <iain@sandoe.co.uk>

            PR c++/94538
            * g++.dg/coroutines/pr94528.C: New test.

[Bug c++/94528] coroutines: ICE building cppcoro in gimplify_expr, at gimplify.c:14399

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94528

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> ---
so fixed