public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/94567] [10 Regression] wrong code at -O2 and -O3 on x86_64-linux-gnu Date: Wed, 15 Apr 2020 23:12:47 +0000 [thread overview] Message-ID: <bug-94567-4-GSkqN3cRKl@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94567-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94567 --- Comment #13 from Jeffrey A. Law <law at redhat dot com> --- Sigh. That code is good in that it's rejecting matching the pattern for the SImode sign bit that we can't implement. For some dumb reason I was thinking it was changing how we split, but it's actually the main condition. So calling it a "hack" was a mistake. The only time we have to widen is when the pos + len exactly hits the sign bit in the operand's mode, which is what I thought my patch did. Certainly we don't want to be changing sizes unnecessarily, that's a given. I guess what I did could be refined to allow that case for CCZmode. Your test of: + || (INTVAL (operands[3]) + INTVAL (operands[4]) + == GET_MODE (operands[2])) Looks wrong. Didn't you mean to get the precision of the mode of operand2?
next prev parent reply other threads:[~2020-04-15 23:12 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-12 2:49 [Bug tree-optimization/94567] New: " qrzhang at gatech dot edu 2020-04-14 6:41 ` [Bug rtl-optimization/94567] [10 Regression] " marxin at gcc dot gnu.org 2020-04-14 11:28 ` law at redhat dot com 2020-04-14 11:45 ` [Bug target/94567] " rguenth at gcc dot gnu.org 2020-04-14 11:48 ` rguenth at gcc dot gnu.org 2020-04-14 11:59 ` law at redhat dot com 2020-04-14 12:45 ` rguenth at gcc dot gnu.org 2020-04-14 13:20 ` law at redhat dot com 2020-04-15 9:57 ` rguenth at gcc dot gnu.org 2020-04-15 16:57 ` jakub at gcc dot gnu.org 2020-04-15 17:10 ` jakub at gcc dot gnu.org 2020-04-15 17:14 ` law at redhat dot com 2020-04-15 17:48 ` jakub at gcc dot gnu.org 2020-04-15 23:12 ` law at redhat dot com [this message] 2020-04-16 12:30 ` jakub at gcc dot gnu.org 2020-04-16 22:45 ` law at redhat dot com 2020-04-17 14:58 ` cvs-commit at gcc dot gnu.org 2020-04-17 15:11 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94567-4-GSkqN3cRKl@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).