From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 5D0CF385DC14; Fri, 17 Apr 2020 15:17:19 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D0CF385DC14
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1587136639;
 bh=RIO8/ZoAn1Al4Na4mjAeHzoC/PABRk/42a3UcvmThnc=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=iVf6R+WGa5vqF3WLJoSkbnXSelE6ORQDkvbN8xFGbNsF0ieScYJ4XVMZuNLOsIMHZ
 Xw3MvjfRgxBByReoFp70y0HkbFj+Lv/epyq3arvPai2u6QdGqLI8mjO+joUstx+79G
 TEGfy9aJF+6S+jyoQ/210Z9LPauY9BiXW3E1TSZo=
From: "tkoenig at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/94578] Incorrect assignment of RESHAPE() result to a
 Fortran pointer
Date: Fri, 17 Apr 2020 15:17:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 8.3.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tkoenig at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94578-4-KYAMOcpldE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94578-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94578-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2020 15:17:19 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94578

--- Comment #9 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Here's what a solution could look like. I am not really sure that this
is the way to go, there may be some corner cases (pointer to an
argument which was passed as a transposed argument?) which this
might get wrong.

diff --git a/libgfortran/generated/maxval_i4.c
b/libgfortran/generated/maxval_i4.c
index abad45b50ae..3a9ed436956 100644
--- a/libgfortran/generated/maxval_i4.c
+++ b/libgfortran/generated/maxval_i4.c
@@ -50,6 +50,7 @@ maxval_i4 (gfc_array_i4 * const restrict retarray,
   index_type delta;
   index_type dim;
   int continue_loop;
+  int ret_factor;

   /* Make dim zero based to avoid confusion.  */
   rank =3D GFC_DESCRIPTOR_RANK (array) - 1;
@@ -112,6 +113,7 @@ maxval_i4 (gfc_array_i4 * const restrict retarray,
          return;

        }
+      ret_factor =3D 1;
     }
   else
     {
@@ -124,12 +126,16 @@ maxval_i4 (gfc_array_i4 * const restrict retarray,
       if (unlikely (compile_options.bounds_check))
        bounds_ifunction_return ((array_t *) retarray, extent,
                                 "return value", "MAXVAL");
+      if (retarray->span !=3D 0)
+       ret_factor =3D retarray->span / sizeof(GFC_INTEGER_4);
+      else
+       ret_factor =3D 1;
     }

   for (n =3D 0; n < rank; n++)
     {
       count[n] =3D 0;
-      dstride[n] =3D GFC_DESCRIPTOR_STRIDE(retarray,n);
+      dstride[n] =3D GFC_DESCRIPTOR_STRIDE(retarray,n) * ret_factor;
       if (extent[n] <=3D 0)
        return;
     }=