public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "howisjw at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/94578] New: Incorrect assignment of RESHAPE() result to a Fortran pointer
Date: Mon, 13 Apr 2020 13:46:13 +0000	[thread overview]
Message-ID: <bug-94578-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94578

            Bug ID: 94578
           Summary: Incorrect assignment of RESHAPE() result to a Fortran
                    pointer
           Product: gcc
           Version: 8.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: howisjw at hotmail dot com
  Target Milestone: ---

The other day, I tried to compile a large Fortran code using gcc 8.3.0. In the
code the reshape function is used and the resulting is assigned to a Fortran
pointer. The results are not what I expected to be. I am not sure if it a bug
or if I do something which is not according to the latest Fortran standard. I
created a simple program (see below) to demostrate the problem. 

If I use the tmp array, like

  tmp     = reshape(source=array2d, shape=shape(array1d))
  array1d = tmp

it all works. I have the impression that under-the-hood the result of the
reshape function is stored in array1d using a some kind of memory copy. This
works fine if array1d is contiguous in memory. However, if array1d is a Fortran
pointer (my case) do not have to be contiguous in memory.


program bug_reshape
  implicit none

  type :: value_and_derivatives
     real(kind=8) :: x,s,t,st,ss,tt
     logical      :: up_to_date
  end type value_and_derivatives

  type :: tsolution
     type(value_and_derivatives) :: x, y
  end type tsolution

  type(tsolution), dimension(3*4), target :: solution

  ! Locals
  integer                                            :: i, j
  type(value_and_derivatives), dimension(3,4)        :: array2d
  type(value_and_derivatives), dimension(:), pointer :: array1d
  type(value_and_derivatives), dimension(3*4)        :: tmp

  array1d => solution%x

  do j=1,4
     do i=1,3
        array2d(i,j) = value_and_derivatives(i*j, i, j, 0.1*i*j, 0.1*i, 0.1*j,
.true.)
     end do
  end do
  array1d = reshape(source=array2d, shape=shape(array1d))

  print*,"--- array2d ---"
  do j=1,4
     do i=1,3
        print '(2(i1,1x),6(e15.7,1x),l)',i,j,array2d(i,j)
     end do
  end do

  print*,"--- array1d ---"
  do i=1,12
     print '(i1,1x,6(e15.7,1x),l)',i,array1d(i)
  end do
end program bug_reshape

Jan-Willem

             reply	other threads:[~2020-04-13 13:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13 13:46 howisjw at hotmail dot com [this message]
2020-04-13 13:53 ` [Bug fortran/94578] " howisjw at hotmail dot com
2020-04-13 13:56 ` howisjw at hotmail dot com
2020-04-14 15:05 ` tkoenig at gcc dot gnu.org
2020-04-14 15:08 ` tkoenig at gcc dot gnu.org
2020-04-16 14:21 ` tkoenig at gcc dot gnu.org
2020-04-16 14:24 ` tkoenig at gcc dot gnu.org
2020-04-17  7:02 ` howisjw at hotmail dot com
2020-04-17 14:16 ` tkoenig at gcc dot gnu.org
2020-04-17 15:17 ` tkoenig at gcc dot gnu.org
2020-04-25 10:29 ` cvs-commit at gcc dot gnu.org
2020-04-27  9:42 ` howisjw at hotmail dot com
2020-04-27 16:57 ` tkoenig at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94578-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).