public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/94593] [OpenMP] c-c++-common/gomp/requires-1.c: Missing diagnostic, test-case issues
Date: Wed, 15 Apr 2020 08:01:38 +0000	[thread overview]
Message-ID: <bug-94593-4-92TITrwwyd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94593-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94593

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2dc9294c3c7c81a6d5e1d4dedf58fea87bbadde6

commit r10-7731-g2dc9294c3c7c81a6d5e1d4dedf58fea87bbadde6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 15 09:59:14 2020 +0200

    openmp: Reject requires directives not at file or namespace scope [PR94593]

    This change started with a bugreport about a typo in one requires testcase
    (diagnosed with -Wunknown-pragmas only), but following discussion lead to
    noting that we do not diagnose restriction that requires directives in
    C/C++ may only appear at file or namespace scope; and several our tests
    violated that.

    2020-04-15  Jakub Jelinek  <jakub@redhat.com>

            PR c/94593
            * c-parser.c (c_parser_pragma) <case PRAGMA_OMP_REQUIRES>: Reject
            requires directive when not at file scope.

            * parser.c (cp_parser_pragma) <case PRAGMA_OMP_REQUIRES>: Reject
            requires directive when not at file or namespace scope.

            * c-c++-common/gomp/requires-1.c: Fix a typo, requries -> requires.
            Move directives to file scope.
            (i): Remove.
            * c-c++-common/gomp/requires-2.c: Move directives to file scope.
            (i, foo): Remove.
            * c-c++-common/gomp/requires-4.c: Move directives to file scope.
            * c-c++-common/gomp/atomic-19.c: Move requires directive to file
scope.
            * c-c++-common/gomp/atomic-20.c: Likewise.
            * c-c++-common/gomp/atomic-21.c: Likewise.
            * c-c++-common/gomp/atomic-22.c: Likewise.
            * gcc.dg/gomp/requires-1.c: New test.
            * g++.dg/gomp/requires-1.C: New test.
            * g++.dg/gomp/requires-2.C: New test.
            * g++.dg/gomp/atomic-18.C: Move requires directive to file scope.

  parent reply	other threads:[~2020-04-15  8:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 12:06 [Bug middle-end/94593] New: " burnus at gcc dot gnu.org
2020-04-14 15:04 ` [Bug middle-end/94593] " jakub at gcc dot gnu.org
2020-04-14 15:21 ` jakub at gcc dot gnu.org
2020-04-14 18:57 ` [Bug c/94593] " jakub at gcc dot gnu.org
2020-04-15  8:01 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-15  8:03 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94593-4-92TITrwwyd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).