public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/94600] Ignored volatile specifier on loop unrolling and bitfield misoptimization
Date: Wed, 15 Apr 2020 07:07:50 +0000	[thread overview]
Message-ID: <bug-94600-4-BYSfP1swYu@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94600-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94600

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
So for example

diff --git a/gcc/expr.c b/gcc/expr.c
index b97c217e86d..a980811c1e9 100644
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -8263,7 +8263,8 @@ expand_constructor (tree exp, rtx target, enum
expand_modifier modifier,
   /* Handle calls that pass values in multiple non-contiguous
      locations.  The Irix 6 ABI has examples of this.  */
   if (target == 0 || ! safe_from_p (target, exp, 1)
-      || GET_CODE (target) == PARALLEL || modifier == EXPAND_STACK_PARM)
+      || GET_CODE (target) == PARALLEL || modifier == EXPAND_STACK_PARM
+      || (GET_CODE (target) == MEM && MEM_VOLATILE_P (target)))
     {
       if (avoid_temp_mem)
        return NULL_RTX;

avoids the constant folding and produces

foo:
        @ args = 0, pretend = 0, frame = 0
        @ frame_needed = 0, uses_anonymous_args = 0
        mov     r3, #655360
        ldr     r2, .L4
        push    {r4, lr}
        ldm     r2, {r4, lr}
        ldr     ip, [r2, #8]
        add     r0, r2, #12
        str     r4, [r3, #44]
        ldm     r0, {r0, r1, r2}
        str     lr, [r3, #48]
        str     ip, [r3, #52]
        str     r0, [r3, #56]
        str     r1, [r3, #60]
        str     r2, [r3, #64]
        pop     {r4, pc}

on arm.

  parent reply	other threads:[~2020-04-15  7:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 23:27 [Bug middle-end/94600] New: " hp at gcc dot gnu.org
2020-04-14 23:32 ` [Bug middle-end/94600] " hp at gcc dot gnu.org
2020-04-14 23:36 ` hp at gcc dot gnu.org
2020-04-15  6:46 ` rguenth at gcc dot gnu.org
2020-04-15  7:05 ` rguenth at gcc dot gnu.org
2020-04-15  7:06 ` rguenth at gcc dot gnu.org
2020-04-15  7:07 ` rguenth at gcc dot gnu.org [this message]
2020-04-15 22:33 ` joseph at codesourcery dot com
2020-04-15 22:45 ` hp at gcc dot gnu.org
2020-07-13  6:09 ` cvs-commit at gcc dot gnu.org
2020-07-13  6:30 ` cvs-commit at gcc dot gnu.org
2020-08-13  3:13 ` cvs-commit at gcc dot gnu.org
2020-12-04 19:29 ` cvs-commit at gcc dot gnu.org
2020-12-04 19:37 ` cvs-commit at gcc dot gnu.org
2021-12-21  2:46 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94600-4-BYSfP1swYu@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).