public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94613] S/390, powerpc: Wrong code generated for vec_sel builtin
Date: Mon, 20 Apr 2020 17:39:01 +0000 [thread overview]
Message-ID: <bug-94613-4-ihTioCFGyL@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94613-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94613
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andreas Krebbel <krebbel@gcc.gnu.org>:
https://gcc.gnu.org/g:2930bb321794c241d8df5591a5bf447bf89c6e82
commit r10-7827-g2930bb321794c241d8df5591a5bf447bf89c6e82
Author: Andreas Krebbel <krebbel@linux.ibm.com>
Date: Mon Apr 20 19:36:33 2020 +0200
PR94613: Fix vec_sel builtin for IBM Z
The vsel instruction is a bit-wise select instruction. Using an
IF_THEN_ELSE to express it in RTL is wrong and leads to wrong code being
generated in the combine pass.
With the patch the pattern is written using bit operations. However,
I've just noticed that the manual still demands a fixed point mode for
AND/IOR and friends although several targets emit bit ops on floating
point vectors (including i386, Power, and s390). So I assume this is a
safe thing to do?!
gcc/ChangeLog:
2020-04-20 Andreas Krebbel <krebbel@linux.ibm.com>
PR target/94613
* config/s390/s390-builtin-types.def: Add 3 new function modes.
* config/s390/s390-builtins.def: Add mode dependent low-level
builtin and map the overloaded builtins to these.
* config/s390/vx-builtins.md ("vec_selV_HW"): Rename to ...
("vsel<V_HW"): ... this and rewrite the pattern with bitops.
gcc/testsuite/ChangeLog:
2020-04-20 Andreas Krebbel <krebbel@linux.ibm.com>
PR target/94613
* gcc.target/s390/zvector/pr94613.c: New test.
* gcc.target/s390/zvector/vec_sel-1.c: New test.
next prev parent reply other threads:[~2020-04-20 17:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 7:01 [Bug rtl-optimization/94613] New: combine: Wrong code due to splitting a simplified IF_THEN_ELSE krebbel at gcc dot gnu.org
2020-04-16 7:02 ` [Bug rtl-optimization/94613] " krebbel at gcc dot gnu.org
2020-04-16 7:05 ` krebbel at gcc dot gnu.org
2020-04-16 7:05 ` krebbel at gcc dot gnu.org
2020-04-16 7:09 ` krebbel at gcc dot gnu.org
2020-04-16 7:10 ` rguenth at gcc dot gnu.org
2020-04-16 7:15 ` rguenth at gcc dot gnu.org
2020-04-16 7:37 ` krebbel at gcc dot gnu.org
2020-04-16 8:21 ` [Bug target/94613] Wrong code generated for vec_sel builtin krebbel at gcc dot gnu.org
2020-04-16 8:28 ` [Bug target/94613] S/390: " krebbel at gcc dot gnu.org
2020-04-16 21:18 ` segher at gcc dot gnu.org
2020-04-20 17:39 ` cvs-commit at gcc dot gnu.org [this message]
2020-05-04 8:39 ` [Bug target/94613] S/390, powerpc: " cvs-commit at gcc dot gnu.org
2020-05-04 8:43 ` cvs-commit at gcc dot gnu.org
2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-07-23 6:52 ` rguenth at gcc dot gnu.org
2021-04-08 12:02 ` rguenth at gcc dot gnu.org
2021-05-04 12:32 ` rguenth at gcc dot gnu.org
2021-05-27 0:57 ` luoxhu at gcc dot gnu.org
2021-10-28 3:18 ` cvs-commit at gcc dot gnu.org
2021-10-28 3:18 ` cvs-commit at gcc dot gnu.org
2021-10-28 6:04 ` luoxhu at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94613-4-ihTioCFGyL@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).