public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "s_gccbugzilla at nedprod dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94649] 16-byte aligned atomic_compare_exchange doesn not generate cmpxcg16b on x86_64
Date: Fri, 07 May 2021 14:44:06 +0000 [thread overview]
Message-ID: <bug-94649-4-LNxzC5vICU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94649-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94649
Niall Douglas <s_gccbugzilla at nedprod dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |s_gccbugzilla at nedprod dot com
--- Comment #4 from Niall Douglas <s_gccbugzilla at nedprod dot com> ---
Relocating my issue from PR 80878 to here:
I got bit by this GCC regression today at work. Consider
https://godbolt.org/z/M9fd7nhdh where
std::atomic<__int128>::compare_exchange_weak() is called with option
-march=sandybridge passed to the command line:
- On GCC 6.4 and earlier, this emits lock cmpxchg16b, as you would expect.
- From GCC 7 up to trunk (12?), this emits __atomic_compare_exchange_16.
- On clang, this emits lock cmpxchg16b, as you would expect.
This is clearly a regression. GCCs before 7 did the right thing. GCCs from 7
onwards do not. clangs with libstdc++ do do the right thing.
Please mark this bug as a regression affecting all versions of GCC from 7 to
trunk.
--- cut ---
NOTE that unlike the original PR above where the struct is a UDT, I am talking
here about std::atomic<__int128>::compare_exchange_weak(). It seems weird that
__int128 is treated as a UDT when the CPU is perfectly capable of hardware CAS.
Common feedback from this and other PRs:
1. Changing this would break ABI
Firstly, I told GCC -march=sandybridge, and we know that libatomic will choose
cmpxchg16b to implement __atomic_compare_exchange_16 because cpuid for
sandybridge will say cmpxchg16b is supported. So, it's the same implementation
for __atomic_compare_exchange_16, nothing breaks here.
2. static const std::atomic<__int128>::load() will segfault
std::atomic<__int128> could examine the macro environment
(__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 et al) and if only 128 bit compare and
swap is available, but 128 bit atomics are not, then std::atomic<__int128>
could be conditionally marked with attribute section to prevent it being stored
into the read only code section.
That said, I don't actually consider static const std::atomic<__int128>::load()
segfaulting important enough to special case, in my opinion.
3. This was changed in GCC 7 because _Atomic is broken
_Atomic is indeed broken, but I am talking about std::atomic the C++ library
type here. As Mr. Wakely said in another PR:
> std::atomic just calls the relevant __atomic built-in for all operations.
> What the built-in does is not up to libstdc++.
... to this I would say both yes and no. __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16
is not defined if the architecture relies on software emulation (libatomic) to
implement 128 bit CAS. So std::atomic<types sizeof(16)>::compare_exchange_X()
*could* examine macros for architecture and presence of
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 and inline some assembler for certain
architectures as a QoI measure, which is not ABI breaking because if
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 is 1, then libatomic will be choosing that
same assembler in any case. Note that I refer to the CAS operation only, for
load and store it's trivial to write CAS based emulations, but you could just
leave those continue to call libatomic.
Ultimately I probably agree that because _Atomic is broken, the compiler is not
the right thing to change here. But libstdc++'s std::atomic implementation is
another matter.
next prev parent reply other threads:[~2021-05-07 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 18:17 [Bug c++/94649] New: " avi@cloudius-systems.com
2020-04-20 7:03 ` [Bug target/94649] " rguenth at gcc dot gnu.org
2020-04-20 11:37 ` avi@cloudius-systems.com
2021-03-14 3:10 ` wuyongwei at gmail dot com
2021-05-07 14:44 ` s_gccbugzilla at nedprod dot com [this message]
2023-02-15 10:56 ` balder at yahooinc dot com
2023-02-15 10:59 ` jakub at gcc dot gnu.org
2023-02-17 7:53 ` balder at yahooinc dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94649-4-LNxzC5vICU@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).