public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "z.zhanghaijian at huawei dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/94665] missed minmax optimization opportunity for if/else structure.
Date: Thu, 23 Apr 2020 01:07:03 +0000 [thread overview]
Message-ID: <bug-94665-4-0uvfnoj2Qw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94665-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94665
--- Comment #18 from z.zhanghaijian at huawei dot com <z.zhanghaijian at huawei dot com> ---
(In reply to Segher Boessenkool from comment #17)
> [ Please don't add other email addresses for me; I get enough mail already,
> I don't need all bugzilla mail in duplicate :-) ]
OK
> (In reply to z.zhanghaijian@huawei.com from comment #16)
> > Ok, I will create a new PR to track this bug, and I will submit a bugfix
> > patch whit that PR.
>
> You can make this PR RESOLVED again, after you made a new PR.
OK, the new PR is PR94708, I will make this PR RESOLVED.
>
> > In addition, I tracked the process of generating fmaxnm/fminnm and found
> > that it was generated in phiopt (minmax_replacement) and if-conversion
> > (noce_try_minmax). In the rtl combine, only fminnm can be generated. Is it
> > necessary for us to improve this optimization in the rtl combine using the
> > above patch in stage1?
>
> Yeah, ifcvt will often do it.
>
> combine can handle max just fine as well; you'll need to track down why
> it doesn't here (I noticed it doesn't as well, it wasn't immediately
> obvious to me what the difference with the min case is).
I will continue to track why fmaxnm is not generated.
next prev parent reply other threads:[~2020-04-23 1:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 3:52 [Bug rtl-optimization/94665] New: " z.zhanghaijian at huawei dot com
2020-04-20 6:43 ` [Bug rtl-optimization/94665] " pinskia at gcc dot gnu.org
2020-04-20 6:45 ` segher at gcc dot gnu.org
2020-04-20 6:45 ` segher at gcc dot gnu.org
2020-04-20 6:47 ` pinskia at gcc dot gnu.org
2020-04-20 7:24 ` z.zhanghaijian at huawei dot com
2020-04-20 7:50 ` segher at gcc dot gnu.org
2020-04-20 8:12 ` z.zhanghaijian at huawei dot com
2020-04-20 11:09 ` segher at gcc dot gnu.org
2020-04-20 11:47 ` z.zhanghaijian at huawei dot com
2020-04-21 9:43 ` segher at gcc dot gnu.org
2020-04-21 9:44 ` segher at gcc dot gnu.org
2020-04-21 10:18 ` segher at gcc dot gnu.org
2020-04-21 10:38 ` z.zhanghaijian at huawei dot com
2020-04-21 10:51 ` z.zhanghaijian at huawei dot com
2020-04-21 11:02 ` z.zhanghaijian at huawei dot com
2020-04-21 17:42 ` segher at gcc dot gnu.org
2020-04-22 6:23 ` z.zhanghaijian at huawei dot com
2020-04-22 17:04 ` segher at gcc dot gnu.org
2020-04-23 1:07 ` z.zhanghaijian at huawei dot com [this message]
2020-04-23 1:08 ` z.zhanghaijian at huawei dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94665-4-0uvfnoj2Qw@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).