public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "valentin.david at codethink dot co.uk" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/94681] New: filesystem::sysmlink_status using stat instead of lstat when --disable-libstdcxx-filesystem-ts
Date: Tue, 21 Apr 2020 08:41:10 +0000 [thread overview]
Message-ID: <bug-94681-4@http.gcc.gnu.org/bugzilla/> (raw)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94681
Bug ID: 94681
Summary: filesystem::sysmlink_status using stat instead of
lstat when --disable-libstdcxx-filesystem-ts
Product: gcc
Version: 9.3.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: valentin.david at codethink dot co.uk
Target Milestone: ---
Created attachment 48321
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48321&action=edit
Proposed fix
std::filesystem::sysmlink_status follows symlinks when GCC has been configured
with --disable-libstdcxx-filesystem-ts, but it works fine when it has been
configured with --enable-libstdcxx-filesystem-ts.
The reason is that libstdc++-v3/src/c++17/fs_ops.cc includes
libstdc++-v3/src/filesystem/ops-common.h which has some requirements in the
configure script that are not executed.
In libstdc++-v3/acinclude.m4, GLIBCXX_CHECK_FILESYSTEM_DEPS is guarded by test
"$enable_libstdcxx_filesystem_ts = yes". But this should be run even if
enable_libstdcxx_filesystem_ts is "no" since
libstdc++-v3/src/filesystem/ops-common.h is used when
--disable-libstdcxx-filesystem-ts is used.
Removing this "if" fixed the issue for me.
While I have not tested master, I believe the issue is still there.
next reply other threads:[~2020-04-21 8:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:41 valentin.david at codethink dot co.uk [this message]
2020-04-21 8:42 ` [Bug libstdc++/94681] " redi at gcc dot gnu.org
2020-04-21 8:55 ` redi at gcc dot gnu.org
2020-08-10 12:22 ` cvs-commit at gcc dot gnu.org
2020-08-10 12:25 ` redi at gcc dot gnu.org
2020-08-10 14:37 ` clyon at gcc dot gnu.org
2020-08-10 16:04 ` redi at gcc dot gnu.org
2020-08-10 18:12 ` cvs-commit at gcc dot gnu.org
2020-09-21 23:00 ` cvs-commit at gcc dot gnu.org
2020-09-21 23:00 ` cvs-commit at gcc dot gnu.org
2020-09-21 23:14 ` cvs-commit at gcc dot gnu.org
2020-09-21 23:14 ` cvs-commit at gcc dot gnu.org
2020-09-21 23:14 ` redi at gcc dot gnu.org
2020-09-21 23:14 ` redi at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94681-4@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).