From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 6A785386F02B; Wed, 22 Apr 2020 07:28:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A785386F02B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1587540526;
 bh=MrbXE9OxC5Mf0ayVbKi8ntyxIhwKzPYH/frTAMWBj0w=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=EHc7NtmNjSW6+0BY3C9tCZ4YpujNhx7rZoWax59jZdwMfSFJQ5WHxQnn6lJ7DSbL2
 gvD35sJLaJGoqeYAPGrYV4bq/K6swvnlYsdygzXPTKB57T+35YP9+6fP6caDl4ZOmq
 djKg0aDQX6YXE+gd87EUjw9YABD/bUAFd8DSZG3s=
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/94703] Small-sized  memcpy leading to unnecessary
 register spillage unless done through a dummy union
Date: Wed, 22 Apr 2020 07:28:46 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc version cf_reconfirmed_on bug_status
 everconfirmed cf_gcctarget
Message-ID: <bug-94703-4-Aocy62JUEJ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94703-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94703-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2020 07:28:46 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94703

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org
            Version|unknown                     |10.0
   Last reconfirmed|                            |2020-04-22
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
             Target|                            |x86_64-*-*

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  We end up with

get4_1 (const void * X)
{
  uint64_t r;
  unsigned int _4;
  uint64_t _6;

  <bb 2> [local count: 1073741824]:
  r =3D 0;
  _4 =3D MEM <unsigned int> [(char * {ref-all})X_3(D)];
  MEM <unsigned int> [(char * {ref-all})&r] =3D _4;
  _6 =3D r;
  r =3D{v} {CLOBBER};
  return _6;

and

get4_nospill (const void * X)
{
  union
  {
    uint64_t u64;
  } u;
  unsigned int _4;
  uint64_t _6;

  <bb 2> [local count: 1073741824]:
  u.u64 =3D 0;
  _4 =3D MEM <unsigned int> [(char * {ref-all})X_3(D)];
  MEM <unsigned int> [(char * {ref-all})&u] =3D _4;
  _6 =3D u.u64;
  u =3D{v} {CLOBBER};
  return _6;

so it's the same on the GIMPLE level but somehow RTL expansion likes
the latter more, expanding 'u' to a register but not 'r'.  Ah,
that's because we have to keep TREE_ADDRESSABLE to prevent 'r' from
being rewritten into SSA but not 'u' ...

Extending DECL_GIMPLE_REG_P to non-vector/comples vars would likely
fix this.

We can also rewrite 'r' into SSA when we use BIT_INSERT_EXPR more
aggressively (not sure if we want that).=