public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/94724] [10 Regression] wrong code at -O0 on x86_64-linux-gnu since r10-7344-gca6c722561ce9b9d
Date: Thu, 23 Apr 2020 19:12:20 +0000	[thread overview]
Message-ID: <bug-94724-4-OgFEuWtG9C@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94724-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94724

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:bca558de2a24b2a78c6a321d6cec384e07759d77

commit r10-7921-gbca558de2a24b2a78c6a321d6cec384e07759d77
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Apr 23 21:11:36 2020 +0200

    tree: Fix up get_narrower [PR94724]

    In the recent get_narrower change, I wanted it to be efficient and avoid
    recursion if there are many nested COMPOUND_EXPRs.  That builds the
    COMPOUND_EXPR nest with the right arguments, but as build2_loc computes
some
    flags like TREE_SIDE_EFFECTS, TREE_CONSTANT and TREE_READONLY, when it
    is called with something that will not be the argument in the end, those
    flags are computed incorrectly.
    So, this patch instead uses an auto_vec and builds them in the reverse
order
    so when they are built, they are built with the correct operands.

    2020-04-23  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/94724
            * tree.c (get_narrower): Instead of creating COMPOUND_EXPRs
            temporarily with non-final second operand and updating it later,
            push COMPOUND_EXPRs into a vector and process it in reverse,
            creating COMPOUND_EXPRs with the final operands.

            * gcc.c-torture/execute/pr94724.c: New test.

  parent reply	other threads:[~2020-04-23 19:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  0:22 [Bug tree-optimization/94724] New: wrong code at -O0 on x86_64-linux-gnu qrzhang at gatech dot edu
2020-04-23  5:21 ` [Bug tree-optimization/94724] [10 Regression] wrong code at -O0 on x86_64-linux-gnu since r10-7344-gca6c722561ce9b9d marxin at gcc dot gnu.org
2020-04-23  8:45 ` [Bug middle-end/94724] " jakub at gcc dot gnu.org
2020-04-23  9:30 ` jakub at gcc dot gnu.org
2020-04-23 19:12 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-23 19:19 ` jakub at gcc dot gnu.org
2020-05-08  7:37 ` cvs-commit at gcc dot gnu.org
2020-05-08  7:49 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94724-4-OgFEuWtG9C@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).