From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id CB36E396DC1D; Fri,  8 May 2020 07:37:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB36E396DC1D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1588923470;
 bh=gN4DDJMVv0lNJNKY9U7aPoTWDzmXxL6E/ig/HBxRLW8=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=hKBtV5f8AGtu/GruQVJq9Eu6Zmdg+knM371Qhuv9WapbQU5DX1etXPgVyz8IOYwOR
 YLdjxvgpy+sKWyOsGcFccfg1dxylaV6pfpARoeiWM1j4T4N4Cv6/jlbIFPOMzBydNd
 aaY9KwHVoEqCW2t9i2nqUrg4KJ6Wze+qXIHzBBjc=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/94724] [10 Regression] wrong code at -O0 on
 x86_64-linux-gnu since r10-7344-gca6c722561ce9b9d
Date: Fri, 08 May 2020 07:37:50 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94724-4-XMwgJSHs27@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94724-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94724-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 08 May 2020 07:37:50 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94724

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a139bc2b492de8a761890a5d299951dede3d8f7b

commit r11-196-ga139bc2b492de8a761890a5d299951dede3d8f7b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri May 8 09:37:09 2020 +0200

    tree: Avoid variable sharing in get_narrower [PR94724]

    On Thu, May 07, 2020 at 02:45:29PM +0200, Thomas Schwinge wrote:
    > >>+      for (tree op =3D win; TREE_CODE (op) =3D=3D COMPOUND_EXPR;
    >
    > ..., and new 'op' variable here.
    >
    > >>+        op =3D TREE_OPERAND (op, 1))
    > >>+     v.safe_push (op);
    > >>+      FOR_EACH_VEC_ELT_REVERSE (v, i, op)
    > >>+     ret =3D build2_loc (EXPR_LOCATION (op), COMPOUND_EXPR,
    > >>+                       TREE_TYPE (win), TREE_OPERAND (op, 0),
    > >>+                       ret);
    > >>+      return ret;
    > >>     }
    > >>   while (TREE_CODE (op) =3D=3D NOP_EXPR)
    > >>     {

    There is no reason for the shadowing and op at this point acts as a
    temporary and will be overwritten in FOR_EACH_VEC_ELT_REVERSE anyway.
    So, we can just s/tree // here.

    2020-05-08  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/94724
            * tree.c (get_narrower): Reuse the op temporary instead of
            shadowing it.=