public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94734] [10 Regression] Program crashes when compiled with -O2 since r10-1892-gb9ef6a2e04bfd013
Date: Fri, 24 Apr 2020 08:34:01 +0000	[thread overview]
Message-ID: <bug-94734-4-kCusNZvjEg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94734-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94734

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah.
add_or_mark_expr could be extended to handle more complex addresses (perhaps
get_inner_reference and hash on the decl + offset expression and taking into
account the bitpos/bitsize then?

Further testcase.  Both foo and bar are miscompiled, baz is fine because arr[7]
is known to be always within the object bounds.

__attribute__((noipa)) int
foo (int n)
{
  int arr[16], s = 0;
  for (int i = 0; i < n; i++)
    {
      if (i < 16)
        arr[i] = i;
    }
  for (int i = 0; i < 16; i++)
    s += arr[i];
  return s;
}

__attribute__((noipa)) int
bar (int n, int x, unsigned long y, unsigned long z)
{
  int arr[16], s = 0;
  arr[4] = 42;
  for (int i = 0; i < n; i++)
    {
      if (x == (i & 0x25))
        arr[y] = i;
    }
  return arr[z];
}

__attribute__((noipa)) int
baz (int n, int x, unsigned long z)
{
  int arr[16], s = 0;
  arr[12] = 42;
  for (int i = 0; i < n; i++)
    {
      if (x == (i & 0x25))
        arr[7] = i;
    }
  return arr[z];
}

int
main ()
{
  if (foo (10374) != 15 * 16 / 2)
    __builtin_abort ();
  if (bar (25, 0x25, (unsigned long) 0xdeadbeefbeefdeadULL, 4) != 42)
    __builtin_abort ();
  if (bar (25, 4, 17, 17) != 22)
    __builtin_abort ();
  if (baz (25, 0x25, 12) != 42)
    __builtin_abort ();
  if (baz (25, 4, 7) != 22)
    __builtin_abort ();
  if (baz (25, 4, 12) != 42)
    __builtin_abort ();
  return 0;
}

  parent reply	other threads:[~2020-04-24  8:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 17:17 [Bug c/94734] New: Program crashes when compiled with GCC 10 john+gcc at hogberg dot online
2020-04-23 18:12 ` [Bug c/94734] " john+gcc at hogberg dot online
2020-04-23 19:19 ` [Bug tree-optimization/94734] [10 Regression] Program crashes when compiled with -O2 since r10-1892-gb9ef6a2e04bfd013 marxin at gcc dot gnu.org
2020-04-23 21:24 ` law at redhat dot com
2020-04-23 23:24 ` jakub at gcc dot gnu.org
2020-04-23 23:25 ` jakub at gcc dot gnu.org
2020-04-24  0:48 ` law at redhat dot com
2020-04-24  5:20 ` jakub at gcc dot gnu.org
2020-04-24  7:52 ` rguenth at gcc dot gnu.org
2020-04-24  7:55 ` rguenth at gcc dot gnu.org
2020-04-24  8:34 ` jakub at gcc dot gnu.org [this message]
2020-04-24  8:59 ` jakub at gcc dot gnu.org
2020-04-24  9:03 ` rguenther at suse dot de
2020-04-24  9:09 ` jakub at gcc dot gnu.org
2020-04-24  9:19 ` jakub at gcc dot gnu.org
2020-04-24  9:22 ` rguenth at gcc dot gnu.org
2020-04-24  9:29 ` jakub at gcc dot gnu.org
2020-04-24 10:37 ` jakub at gcc dot gnu.org
2020-04-24 22:10 ` cvs-commit at gcc dot gnu.org
2020-04-24 22:24 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94734-4-kCusNZvjEg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).