public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "colomar.6.4.3 at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug analyzer/94754] New: -fanalyzer false positive due to it ignoring previous if Date: Sat, 25 Apr 2020 00:20:13 +0000 [thread overview] Message-ID: <bug-94754-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94754 Bug ID: 94754 Summary: -fanalyzer false positive due to it ignoring previous if Product: gcc Version: 10.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: analyzer Assignee: dmalcolm at gcc dot gnu.org Reporter: colomar.6.4.3 at gmail dot com Target Milestone: --- The analyzer follows branches that are incompatible (sometimes). Code to reproduce the bug: [[gnu::nonnull]] static void init_x(int cond, int **x, int *y) { if (!cond) return; *x = y; } int foo(int cond) { int *x; int y = 7; if (cond < 2) return -1; /* cond >= 2 != 0, so it will initialize x */ init_x(cond, &x, &y); return *x; } $ gcc-10 -c false_positive.c -o foo -fanalyzer In function ‘foo’: false_positive.c:22:9: warning: use of uninitialized value ‘x’ [CWE-457] [-Wanalyzer-use-of-uninitialized-value] 22 | return *x; | ^~ ‘foo’: events 1-4 | | 11 | int foo(int cond) | | ^~~ | | | | | (1) entry to ‘foo’ |...... | 16 | if (cond < 2) | | ~ | | | | | (2) following ‘false’ branch (when ‘cond > 1’)... |...... | 20 | init_x(cond, &x, &y); | | ~~~~~~~~~~~~~~~~~~~~ | | | | | (3) ...to here | | (4) calling ‘init_x’ from ‘foo’ | +--> ‘init_x’: events 5-7 | | 3 | void init_x(int cond, int **x, int *y) | | ^~~~~~ | | | | | (5) entry to ‘init_x’ |...... | 6 | if (!cond) | | ~ | | | | | (6) following ‘true’ branch (when ‘cond == 0’)... !!! cond == 0, but previously it assumed cond > 1 !!! | 7 | return; | | ~~~~~~ | | | | | (7) ...to here | <------+ | ‘foo’: events 8-9 | | 20 | init_x(cond, &x, &y); | | ^~~~~~~~~~~~~~~~~~~~ | | | | | (8) returning to ‘foo’ from ‘init_x’ | 21 | | 22 | return *x; | | ~~ | | | | | (9) use of uninitialized value ‘x’ here | $ ___________________________________________________ But. - If I copy&paste (manual inline) `init_x` code inside `foo`, the warning goes away. - If I use pointers instead of double pointers (`void init_x(int cond, int *x, int y)`), the warning goes away.
next reply other threads:[~2020-04-25 0:20 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-25 0:20 colomar.6.4.3 at gmail dot com [this message] 2020-04-25 0:35 ` [Bug analyzer/94754] " colomar.6.4.3 at gmail dot com 2020-04-28 13:26 ` cvs-commit at gcc dot gnu.org 2020-04-28 13:33 ` dmalcolm at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94754-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).