public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug go/94766] New: gcc/go/gofrontend/gogo.h:1076:25: performance: Function parameter 'afnname' should be passed by const reference. [passedByValue]
@ 2020-04-25 20:22 dcb314 at hotmail dot com
2020-04-25 20:31 ` [Bug go/94766] " dcb314 at hotmail dot com
2020-05-11 23:28 ` ian at airs dot com
0 siblings, 2 replies; 3+ messages in thread
From: dcb314 at hotmail dot com @ 2020-04-25 20:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94766
Bug ID: 94766
Summary: gcc/go/gofrontend/gogo.h:1076:25: performance:
Function parameter 'afnname' should be passed by const
reference. [passedByValue]
Product: gcc
Version: 10.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: go
Assignee: ian at airs dot com
Reporter: dcb314 at hotmail dot com
CC: cmang at google dot com
Target Milestone: ---
Source code is
Specific_type_function(Type* atype, Named_type* aname, int64_t asize,
Specific_type_function_kind akind,
const std::string afnname,
Function_type* afntype)
Suggest new code
Specific_type_function(Type* atype, Named_type* aname, int64_t asize,
Specific_type_function_kind akind,
const std::string & afnname,
Function_type* afntype)
^ permalink raw reply [flat|nested] 3+ messages in thread* [Bug go/94766] gcc/go/gofrontend/gogo.h:1076:25: performance: Function parameter 'afnname' should be passed by const reference. [passedByValue] 2020-04-25 20:22 [Bug go/94766] New: gcc/go/gofrontend/gogo.h:1076:25: performance: Function parameter 'afnname' should be passed by const reference. [passedByValue] dcb314 at hotmail dot com @ 2020-04-25 20:31 ` dcb314 at hotmail dot com 2020-05-11 23:28 ` ian at airs dot com 1 sibling, 0 replies; 3+ messages in thread From: dcb314 at hotmail dot com @ 2020-04-25 20:31 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94766 --- Comment #1 from David Binderman <dcb314 at hotmail dot com> --- Similar thing with file gcc/go/gofrontend/names.cc: trunk.git/gcc/go/gofrontend/names.cc:1027:47: performance: Function parameter 'pkgpath' should be passed by const reference. [passedByValue] Source code is std::string Gogo::type_descriptor_list_symbol(std::string pkgpath) { return pkgpath + "..types"; } ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug go/94766] gcc/go/gofrontend/gogo.h:1076:25: performance: Function parameter 'afnname' should be passed by const reference. [passedByValue] 2020-04-25 20:22 [Bug go/94766] New: gcc/go/gofrontend/gogo.h:1076:25: performance: Function parameter 'afnname' should be passed by const reference. [passedByValue] dcb314 at hotmail dot com 2020-04-25 20:31 ` [Bug go/94766] " dcb314 at hotmail dot com @ 2020-05-11 23:28 ` ian at airs dot com 1 sibling, 0 replies; 3+ messages in thread From: ian at airs dot com @ 2020-05-11 23:28 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94766 Ian Lance Taylor <ian at airs dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Ian Lance Taylor <ian at airs dot com> --- Fixed by https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=2f4aeb2f53d96690953fabab487fd1d922f1c95f Thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-11 23:28 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-25 20:22 [Bug go/94766] New: gcc/go/gofrontend/gogo.h:1076:25: performance: Function parameter 'afnname' should be passed by const reference. [passedByValue] dcb314 at hotmail dot com 2020-04-25 20:31 ` [Bug go/94766] " dcb314 at hotmail dot com 2020-05-11 23:28 ` ian at airs dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).