public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "simon.brass at desy dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/94788] [10 Regression] Severe regression leading to double free in tcache
Date: Mon, 27 Apr 2020 17:09:40 +0000	[thread overview]
Message-ID: <bug-94788-4-a5nkoCNp5d@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94788-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94788

--- Comment #7 from Simon Braß <simon.brass at desy dot de> ---
(In reply to Simon Braß from comment #6)
> (In reply to Richard Biener from comment #3)
> > Can you maybe bisect this to a specific (fortran) commit in GCC?
> 
> FYI, I'm hooking up with the bisect (I'm a colleague of Jürgen).
> I will post an update as fast as possible, reasonably, tomorrow.
> 
> Cheers,
> Simon.

After bisecting the commits of the last 8 days, the offending commit is:

Author: Thomas König <tkoenig@gcc.gnu.org>  2020-04-23 20:30:01
Committer: Thomas König <tkoenig@gcc.gnu.org>  2020-04-23 20:30:01
Parent: dcf69ac5448fd6a16137cfe9fe6deadd0ec0243d (coroutines, libstdc++-v3:
Update to n4861 C++20 DIS.)
Child:  bca558de2a24b2a78c6a321d6cec384e07759d77 (tree: Fix up get_narrower
[PR94724])
Branches: master, remotes/origin/devel/c++-coroutines, remotes/origin/master
Follows: misc/cutover-git
Precedes: 

    Fix PR 93956, wrong pointer when returned via function.

    This one took a bit of detective work.  When array pointers point
    to components of derived types, we currently set the span field
    and then create an array temporary when we pass the array
    pointer to a procedure as a non-pointer or non-target argument.
    (This is inefficient, but that's for another release).

    Now, the compiler detected this case when there was a direct assignment
    like p => a%b, but not when p was returned either as a function result
    or via an argument.  This patch fixes that.

    2020-04-23  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/93956
        * expr.c (gfc_check_pointer_assign): Also set subref_array_pointer
        when a function returns a pointer.
        * interface.c (gfc_set_subref_array_pointer_arg): New function.
        (gfc_procedure_use): Call it.

    2020-04-23  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/93956
        * gfortran.dg/pointer_assign_13.f90: New test.

  parent reply	other threads:[~2020-04-27 17:09 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  8:38 [Bug fortran/94788] New: " juergen.reuter at desy dot de
2020-04-27  8:38 ` [Bug fortran/94788] " juergen.reuter at desy dot de
2020-04-27  9:46 ` juergen.reuter at desy dot de
2020-04-27 10:27 ` [Bug fortran/94788] [10 Regression] " rguenth at gcc dot gnu.org
2020-04-27 10:41 ` juergen.reuter at desy dot de
2020-04-27 12:19 ` juergen.reuter at desy dot de
2020-04-27 12:49 ` simon.brass at desy dot de
2020-04-27 17:09 ` simon.brass at desy dot de [this message]
2020-04-27 17:26 ` tkoenig at gcc dot gnu.org
2020-04-27 17:36 ` juergen.reuter at desy dot de
2020-04-27 18:30 ` tkoenig at gcc dot gnu.org
2020-04-27 19:26 ` juergen.reuter at desy dot de
2020-04-27 19:33 ` juergen.reuter at desy dot de
2020-04-27 20:39 ` juergen.reuter at desy dot de
2020-04-27 20:40 ` juergen.reuter at desy dot de
2020-04-27 20:40 ` juergen.reuter at desy dot de
2020-04-27 21:15 ` juergen.reuter at desy dot de
2020-04-27 21:38 ` tkoenig at gcc dot gnu.org
2020-04-27 21:51 ` cvs-commit at gcc dot gnu.org
2020-04-27 21:55 ` [Bug fortran/94788] [8/9 " tkoenig at gcc dot gnu.org
2020-04-27 22:02 ` juergen.reuter at desy dot de
2020-04-27 22:23 ` kargl at gcc dot gnu.org
2020-04-27 22:33 ` juergen.reuter at desy dot de
2020-04-28  5:57 ` tkoenig at gcc dot gnu.org
2020-04-28  8:02 ` burnus at gcc dot gnu.org
2020-04-28  8:12 ` juergen.reuter at desy dot de
2020-04-28  8:17 ` juergen.reuter at desy dot de
2020-04-28  9:13 ` tkoenig at gcc dot gnu.org
2020-04-28 11:17 ` juergen.reuter at desy dot de
2020-04-28 11:36 ` juergen.reuter at desy dot de
2020-04-28 14:06 ` juergen.reuter at desy dot de
2020-04-29  0:38 ` juergen.reuter at desy dot de
2020-04-29  9:09 ` juergen.reuter at desy dot de
2020-04-29 18:32 ` tkoenig at gcc dot gnu.org
2020-04-29 21:58 ` juergen.reuter at desy dot de
2020-04-30 16:31 ` tkoenig at gcc dot gnu.org
2020-04-30 16:35 ` juergen.reuter at desy dot de
2020-04-30 16:49 ` tkoenig at gcc dot gnu.org
2020-04-30 17:37 ` juergen.reuter at desy dot de
2020-04-30 17:38 ` juergen.reuter at desy dot de
2020-05-01 12:27 ` tkoenig at gcc dot gnu.org
2020-05-01 12:53 ` cvs-commit at gcc dot gnu.org
2020-05-01 12:55 ` cvs-commit at gcc dot gnu.org
2020-05-02 15:33 ` cvs-commit at gcc dot gnu.org
2020-05-02 19:51 ` cvs-commit at gcc dot gnu.org
2020-05-21 10:42 ` tkoenig at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94788-4-a5nkoCNp5d@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).