From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 76587385841A; Mon, 16 Jan 2023 10:48:17 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76587385841A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1673866097;
	bh=HSNIvRFzaUuXyk9o4WqQKMjfTCRNZc0USSJFDRgQVyc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=D5zmD5XxTMwz4cGWqffii2LMCLa+s6R/ZPttbZCrjh6llStPVnHtS5vfjOYVuXy+E
	 rppBxCYtaI/uXUNxvbir48z0XCxS0Ur5i9VX64uJzbzJu49HHgbEaGBcL4xI+NO+Bl
	 ZWk/hT3SiP/hgWOMQnBaOAob/mxsjWBNMdOIc4iI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94793] Failure to optimize clz idiom
Date: Mon, 16 Jan 2023 10:48:04 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: andrew.carlotti at arm dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94793-4-LeuAMGGE7f@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94793-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94793-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94793

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Carlotti <acarlotti@gcc.gnu.or=
g>:

https://gcc.gnu.org/g:d347fbf774dc50bf7511f4dc6bc74547ed364995

commit r13-5193-gd347fbf774dc50bf7511f4dc6bc74547ed364995
Author: Andrew Carlotti <andrew.carlotti@arm.com>
Date:   Thu Nov 10 15:56:51 2022 +0000

    Add cltz_complement idiom recognition

    This recognises patterns of the form:
    while (n) { n >>=3D 1 }

    This patch results in improved (but still suboptimal) codegen:

    foo (unsigned int b) {
        int c =3D 0;

        while (b) {
            b >>=3D 1;
            c++;
        }

        return c;
    }

    foo:
    .LFB11:
            .cfi_startproc
            cbz     w0, .L3
            clz     w1, w0
            tst     x0, 1
            mov     w0, 32
            sub     w0, w0, w1
            csel    w0, w0, wzr, ne
            ret

    The conditional is unnecessary. phiopt could recognise a redundant csel
    (using cond_removal_in_builtin_zero_pattern) when one of the inputs is a
    clz call, but it cannot recognise the redunancy when the input is (e.g.)
    (32 - clz).

    I could perhaps extend this function to recognise this pattern in a lat=
er
    patch, if this is a good place to recognise more patterns.

    gcc/ChangeLog:

            PR tree-optimization/94793
            * tree-scalar-evolution.cc (expression_expensive_p): Add checks
            for c[lt]z optabs.
            * tree-ssa-loop-niter.cc (build_cltz_expr): New.
            (number_of_iterations_cltz_complement): New.
            (number_of_iterations_bitcount): Add call to the above.

    gcc/testsuite/ChangeLog:

            * lib/target-supports.exp (check_effective_target_clz)
            (check_effective_target_clzl, check_effective_target_clzll)
            (check_effective_target_ctz, check_effective_target_clzl)
            (check_effective_target_ctzll): New.
            * gcc.dg/tree-ssa/cltz-complement-max.c: New test.
            * gcc.dg/tree-ssa/clz-complement-char.c: New test.
            * gcc.dg/tree-ssa/clz-complement-int.c: New test.
            * gcc.dg/tree-ssa/clz-complement-long-long.c: New test.
            * gcc.dg/tree-ssa/clz-complement-long.c: New test.
            * gcc.dg/tree-ssa/ctz-complement-char.c: New test.
            * gcc.dg/tree-ssa/ctz-complement-int.c: New test.
            * gcc.dg/tree-ssa/ctz-complement-long-long.c: New test.
            * gcc.dg/tree-ssa/ctz-complement-long.c: New test.=