public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/94808] [ICE] [Regression] Segfault during diagnostics from concept check failure
Date: Wed, 29 Apr 2020 02:08:55 +0000	[thread overview]
Message-ID: <bug-94808-4-XqIDHwU8bf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94808-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94808

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:43439d5e8424f3a746003ef8953e1cdc120fbbd7

commit r10-8024-g43439d5e8424f3a746003ef8953e1cdc120fbbd7
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Apr 28 21:45:54 2020 -0400

    c++: Parameter pack in requires parameter list [PR94808]

    When printing the substituted parameter list of a requires-expression as
    part of the "in requirements with ..." context line during concepts
    diagnostics, we weren't considering that substitution into a parameter
    pack can yield zero or multiple parameters.

    This patch changes the way we print the parameter list of a
    requires-expression in print_requires_expression_info.  We now print the
    dependent form of the parameter list (along with its template parameter
    mapping) instead of printing its substituted form.  Besides being an
    improvement in its own, this also sidesteps the substitution issue in the
    PR altogether.

    gcc/cp/ChangeLog:

            PR c++/94808
            * error.c (print_requires_expression_info): Print the dependent
            form of the parameter list with its template parameter mapping,
            rather than printing the substituted form.

    gcc/testsuite/ChangeLog:

            PR c++/94808
            * g++.dg/concepts/diagnostic12.C: New test.
            * g++.dg/concepts/diagnostic5.C: Adjust dg-message.

  parent reply	other threads:[~2020-04-29  2:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 20:33 [Bug c++/94808] New: " eric.niebler at gmail dot com
2020-04-28 12:12 ` [Bug c++/94808] " ppalka at gcc dot gnu.org
2020-04-29  2:08 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-29  2:10 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94808-4-XqIDHwU8bf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).