public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/94831] [10 Regression] vector<float[2]> no longer compiles
Date: Tue, 28 Apr 2020 22:48:36 +0000	[thread overview]
Message-ID: <bug-94831-4-JXl4xvT0EA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94831-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94831

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:162c40a4c127cc55d701bb8760e17708d0ca2fe0

commit r10-8021-g162c40a4c127cc55d701bb8760e17708d0ca2fe0
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Apr 28 23:26:21 2020 +0100

    libstdc++: Fix regression in std::_Construct (PR 94831)

    By trying to reuse the existing std::_Construct function as a wrapper
    for std::construct_at I introduced regressions, because changing
    std::_Construct to return non-void made it ill-formed for array types.

    The solution is to revert _Construct to its former state, and change
    allocator_traits::construct to explicitly call construct_at instead.
    This decouples all the existing callers of _Construct from the new
    construct_at requirements.

            PR libstdc++/94831
            * include/bits/alloc_traits.h (_S_construct): Restore placement
            new-expression for C++11/14/17 and call std::construct_at directly
            for C++20.
            * include/bits/stl_construct.h (_Construct): Revert to
non-constexpr
            function returning void.
            * testsuite/20_util/specialized_algorithms/
            uninitialized_value_construct/94831.cc: New test.
            * testsuite/23_containers/vector/cons/94831.cc: New test.

  parent reply	other threads:[~2020-04-28 22:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 19:45 [Bug libstdc++/94831] New: " redi at gcc dot gnu.org
2020-04-28 19:46 ` [Bug libstdc++/94831] " redi at gcc dot gnu.org
2020-04-28 20:01 ` redi at gcc dot gnu.org
2020-04-28 21:39 ` redi at gcc dot gnu.org
2020-04-28 22:48 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-28 22:54 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94831-4-JXl4xvT0EA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).