public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "gabravier at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94834] New: Failure to optimize loop bswap pattern
Date: Tue, 28 Apr 2020 22:35:21 +0000	[thread overview]
Message-ID: <bug-94834-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94834

            Bug ID: 94834
           Summary: Failure to optimize loop bswap pattern
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gabravier at gmail dot com
  Target Milestone: ---

uint32_t load(const uint8_t* data)
{
    uint32_t val = 0;
    for (int i = 0; i < sizeof(val) * CHAR_BIT; i += CHAR_BIT)
    {
        val |= *data++ << i;
    }
    return val;
}

This can be optimized to a single 32-bit load. LLVM does this transformation,
gcc just unrolls the loop and misses the transformation.

LLVM gives :

load(unsigned char const*): # @load(unsigned char const*)
  mov eax, dword ptr [rdi]
  ret

GCC gives :

load(unsigned char const*):
  movzx edx, BYTE PTR [rdi+1]
  movzx eax, BYTE PTR [rdi]
  sal edx, 8
  or edx, eax
  movzx eax, BYTE PTR [rdi+2]
  sal eax, 16
  or edx, eax
  movzx eax, BYTE PTR [rdi+3]
  sal eax, 24
  or eax, edx
  ret

See also https://godbolt.org/z/kmYTLZ

             reply	other threads:[~2020-04-28 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 22:35 gabravier at gmail dot com [this message]
2020-04-29  7:08 ` [Bug tree-optimization/94834] " rguenth at gcc dot gnu.org
2020-04-29  9:40 ` gabravier at gmail dot com
2021-09-04 21:33 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94834-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).