public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/94842] [8/9/10 Regression] internal compiler error: in gimplify_label_expr, at gimplify.c:2573 Date: Thu, 07 May 2020 13:27:44 +0000 [thread overview] Message-ID: <bug-94842-4-6sS4akB9It@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94842-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94842 --- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:61fb8963c22d91152a9c46a3512307bef3b3d7f7 commit r10-8109-g61fb8963c22d91152a9c46a3512307bef3b3d7f7 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Apr 30 21:48:30 2020 +0200 c: Fix ICE with _Atomic side-effect in nested fn param decls [PR94842] If there are _Atomic side-effects in the parameter declarations of non-nested function, when they are parsed, current_function_decl is NULL, the create_artificial_label created labels during build_atomic* are then adjusted by store_parm_decls through set_labels_context_r callback. Unfortunately, if such thing happens in nested function parameter declarations, while those decls are parsed current_function_decl is the parent function (and am not sure it is a good idea to temporarily clear it, some code perhaps should be aware it is in a nested function, or it can refer to variables from the parent function etc.) and that means store_param_decls through set_labels_context_r doesn't adjust anything. As those labels are emitted in the nested function body rather than in the parent, I think it is ok to override the context in those cases. 2020-04-30 Jakub Jelinek <jakub@redhat.com> PR c/94842 * c-decl.c (set_labels_context_r): In addition to context-less LABEL_DECLs adjust also LABEL_DECLs with context equal to parent function if any. (store_parm_decls): Adjust comment. * gcc.dg/pr94842.c: New test.
next prev parent reply other threads:[~2020-05-07 13:27 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 6:51 [Bug c/94842] New: " anbu1024.me at gmail dot com 2020-04-29 7:18 ` [Bug c/94842] " rguenth at gcc dot gnu.org 2020-04-29 13:28 ` jakub at gcc dot gnu.org 2020-04-29 21:27 ` joseph at codesourcery dot com 2020-04-30 10:32 ` jakub at gcc dot gnu.org 2020-04-30 10:33 ` jakub at gcc dot gnu.org 2020-04-30 19:49 ` [Bug c/94842] [8/9/10/11 " cvs-commit at gcc dot gnu.org 2020-04-30 19:49 ` [Bug c/94842] [8/9/10 " jakub at gcc dot gnu.org 2020-05-07 13:27 ` cvs-commit at gcc dot gnu.org [this message] 2020-05-07 13:33 ` [Bug c/94842] [8/9 " jakub at gcc dot gnu.org 2020-05-08 3:02 ` paul.hua.gm at gmail dot com 2020-09-16 19:21 ` cvs-commit at gcc dot gnu.org 2020-09-17 17:48 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94842-4-6sS4akB9It@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).