public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/94849] Improper parameter validation in libsanitizer for fopen64
Date: Thu, 30 Apr 2020 19:03:05 +0000	[thread overview]
Message-ID: <bug-94849-4-VAMx0dNnN9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94849-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94849

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org

--- Comment #8 from Martin Sebor <msebor at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #3)
> One possible improvement can be decoration of the filename
> with non-null argument (in Glibc).

Agreed (unless Glibc wants to support nulls here, in which case it should
document it as an extension).  Another improvement is to declare fopen and
other functions that expect string arguments with attribute access read_only
(so for fopen both the file and mode arguments).  That would let GCC diagnose
calls that pass in valid pointers that don't point to strings (e.g., just
past-the-end pointers).  This would be a useful follow-up on
https://sourceware.org/bugzilla/show_bug.cgi?id=25219.

  parent reply	other threads:[~2020-04-30 19:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 14:22 [Bug sanitizer/94849] New: " rachel at rachelmant dot com
2020-04-29 14:28 ` [Bug sanitizer/94849] " marxin at gcc dot gnu.org
2020-04-29 14:30 ` jakub at gcc dot gnu.org
2020-04-29 14:33 ` marxin at gcc dot gnu.org
2020-04-29 14:38 ` rachel at rachelmant dot com
2020-04-29 14:53 ` jakub at gcc dot gnu.org
2020-04-29 15:03 ` rachel at rachelmant dot com
2020-04-29 15:52 ` rachel at rachelmant dot com
2020-04-30 19:03 ` msebor at gcc dot gnu.org [this message]
2020-05-04 18:12 ` marxin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94849-4-VAMx0dNnN9@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).