[Bug c++/94907] [10/11 Regression] ICE: Segmentation fault (in check_return_expr) since r10-8016-gbce54ed494fd0e61

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94907

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:3d4c7e05de438fb0672f376e628c18812eea8982

commit r10-8114-g3d4c7e05de438fb0672f376e628c18812eea8982
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed May 6 23:36:31 2020 +0200

    c++: Don't synthesize sfk_comparison method multiple times [PR94907]

    On the following testcase we ICE, because synthesize_method is called twice
    on the same sfk_comparison method fndecl, the first time it works fine
    because start_preparsed_function in that case sets both
    current_function_decl and cfun, but second time it is called it only sets
    the former and keeps cfun NULL, so we ICE when trying to store
    current_function_returns_value.
    I think it is just wrong to call synthesize_method multiple times, and most
    synthesize_method callers avoid that by not calling it if DECL_INITIAL is
    already set, so this patch does that too.

    2020-05-06  Jakub Jelinek  <jakub@redhat.com>

            PR c++/94907
            * method.c (defaulted_late_check): Don't call synthesize_method
            on constexpr sfk_comparison if it has been called on it already.

            * g++.dg/cpp2a/spaceship-synth8.C: New test.