public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94920] Failure to optimize abs pattern from arithmetic with selected operands based on comparisons with 0
Date: Thu, 21 Jul 2022 21:27:39 +0000	[thread overview]
Message-ID: <bug-94920-4-ClFkIWdktz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94920-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94920

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Sam Feifer <sfeifer@gcc.gnu.org>:

https://gcc.gnu.org/g:633e9920589ddfaf2d6da1c24ce99b18a2638db4

commit r13-1785-g633e9920589ddfaf2d6da1c24ce99b18a2638db4
Author: Sam Feifer <sfeifer@redhat.com>
Date:   Thu Jul 21 16:31:41 2022 -0400

    match.pd: Add new abs pattern [PR94920]

    This patch is intended to fix a missed optimization in match.pd. It
optimizes (x >= 0 ? x : 0) + (x <= 0 ? -x : 0) to just abs(x). Additionally,
the pattern (x <= 0 ? -x : 0) now gets optimized to max(-x, 0), which helps
with the other simplification rule.

    Tests are also included to be added to the testsuite.

    Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?

            PR tree-optimization/94920

    gcc/ChangeLog:

            * match.pd (x >= 0 ? x : 0) + (x <= 0 ? -x : 0): New
simplification.
                       (x <= 0 ? -x : 0): New simplification.

    gcc/testsuite/ChangeLog:

            * g++.dg/pr94920-1.C: New test.
            * g++.dg/pr94920.C: New test.
            * gcc.dg/pr94920-2.c: New test.

  parent reply	other threads:[~2022-07-21 21:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 10:53 [Bug tree-optimization/94920] New: " gabravier at gmail dot com
2020-05-04  6:37 ` [Bug tree-optimization/94920] " rguenth at gcc dot gnu.org
2021-08-14 23:58 ` pinskia at gcc dot gnu.org
2022-07-21 21:27 ` cvs-commit at gcc dot gnu.org [this message]
2022-07-27 10:04 ` cvs-commit at gcc dot gnu.org
2022-07-27 10:27 ` gabravier at gmail dot com
2022-08-06  8:14 ` paul.hua.gm at gmail dot com
2022-08-25 22:20 ` pinskia at gcc dot gnu.org
2022-08-25 22:23 ` pinskia at gcc dot gnu.org
2022-10-14 17:56 ` danglin at gcc dot gnu.org
2023-03-04 22:35 ` sandra at gcc dot gnu.org
2023-09-17 16:44 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94920-4-ClFkIWdktz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).