public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94920] Failure to optimize abs pattern from arithmetic with selected operands based on comparisons with 0
Date: Thu, 25 Aug 2022 22:23:18 +0000	[thread overview]
Message-ID: <bug-94920-4-JpQpRYztkY@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94920-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94920

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #7)
> (In reply to Andrew Pinski from comment #6)
> > (In reply to Paul Hua from comment #5)
> > > 
> > > Yes, we should do. This also fails the ABS_EXPR scan-tree-dump on LoongArch.
> > 
> > And on riscv32. I will look into that failure later this week.
> 
> I am suspecting it is because for both LoongArch and RISCV,
> logical-op-non-short-circuit defualts to 0. I am going to debug it right now.

Oh I see the issue. it is not related at all to logical-op-non-short-circuit
but rather than the testcase should be split into two, one for the scalar and
one for the vector case. And then the vector case should match not at optimized
but right before vector lowering happens, maybe in forwprop1 or 2.

  parent reply	other threads:[~2022-08-25 22:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 10:53 [Bug tree-optimization/94920] New: " gabravier at gmail dot com
2020-05-04  6:37 ` [Bug tree-optimization/94920] " rguenth at gcc dot gnu.org
2021-08-14 23:58 ` pinskia at gcc dot gnu.org
2022-07-21 21:27 ` cvs-commit at gcc dot gnu.org
2022-07-27 10:04 ` cvs-commit at gcc dot gnu.org
2022-07-27 10:27 ` gabravier at gmail dot com
2022-08-06  8:14 ` paul.hua.gm at gmail dot com
2022-08-25 22:20 ` pinskia at gcc dot gnu.org
2022-08-25 22:23 ` pinskia at gcc dot gnu.org [this message]
2022-10-14 17:56 ` danglin at gcc dot gnu.org
2023-03-04 22:35 ` sandra at gcc dot gnu.org
2023-09-17 16:44 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94920-4-JpQpRYztkY@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).