public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug ipa/94947] New: -fipa-pta + pthread_once crash
@ 2020-05-04 22:07 corydoras at ridiculousfish dot com
2020-05-05 4:16 ` [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b marxin at gcc dot gnu.org
` (14 more replies)
0 siblings, 15 replies; 16+ messages in thread
From: corydoras at ridiculousfish dot com @ 2020-05-04 22:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
Bug ID: 94947
Summary: -fipa-pta + pthread_once crash
Product: gcc
Version: 9.3.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: ipa
Assignee: unassigned at gcc dot gnu.org
Reporter: corydoras at ridiculousfish dot com
CC: marxin at gcc dot gnu.org
Target Milestone: ---
fish-shell is seeing a SIGSEGV under std::call_once with -fipa-pta, which I
have reduced to the following:
1. Store a noop void->void function pointer into a local variable
2. Point a global variable at the local
3. Use pthread_once to invoke a trampoline, which in turn dereferences the
global to call the noop
This crashes with `-O1 -fipa-pta`, and the crash disappears if `fipa-pta` is
deleted.
Original test case (requires musl):
https://gist.github.com/ridiculousfish/0a24a98e7634b78e77a0351501576ee8
Reduced test case (also available at
https://gist.github.com/ridiculousfish/3cff64438154a20765e527be11f7cc76):
```
extern "C" void pthread_once(int *, void());
namespace std
{
extern __thread void (*__once_call)();
extern "C" void __once_proxy();
}; // namespace std
static void noop() {}
using voidfunc = void (*)();
static voidfunc *vp;
static void call_vp()
{
(*vp)();
}
int main()
{
using namespace std;
voidfunc vf = noop;
vp = &vf;
__once_call = call_vp;
int once{0};
pthread_once(&once, __once_proxy);
return 0;
}
```
To reproduce, on Linux:
g++ -O1 -fipa-pta -std=c++11 -lpthread output.cpp
./a.out
and it should SIGSEGV under `call_vp`
gcc -v:
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib
--libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info
--with-pkgversion='Arch Linux 9.3.0-1'
--with-bugurl=https://bugs.archlinux.org/
--enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++,d --enable-shared
--enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch
--disable-libssp --enable-gnu-unique-object --enable-linker-build-id
--enable-lto --enable-plugin --enable-install-libiberty
--with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib
--disable-werror --enable-checking=release --enable-default-pie
--enable-default-ssp --enable-cet=auto gdc_include_dir=/usr/include/dlang/gdc
Thread model: posix
gcc version 9.3.0 (Arch Linux 9.3.0-1)
(Originally reported as https://github.com/fish-shell/fish-shell/issues/6962)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
@ 2020-05-05 4:16 ` marxin at gcc dot gnu.org
2020-05-05 6:59 ` rguenth at gcc dot gnu.org
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-05-05 4:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |5.4.0
Status|UNCONFIRMED |NEW
Known to fail| |11.0, 6.4.0
CC| |rguenth at gcc dot gnu.org
Last reconfirmed| |2020-05-05
Summary|-fipa-pta + pthread_once |[8/9/10/11 Regression]
|crash |-fipa-pta + pthread_once
| |crash since
| |r6-5684-g47e5754e17e9ac3b
Ever confirmed|0 |1
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, started with r6-5684-g47e5754e17e9ac3b.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
2020-05-05 4:16 ` [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b marxin at gcc dot gnu.org
@ 2020-05-05 6:59 ` rguenth at gcc dot gnu.org
2020-05-05 7:14 ` rguenth at gcc dot gnu.org
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-05 6:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Target Milestone|--- |8.5
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed. It's a little tricky but I think it boils down to
extern void abort ();
extern void baz ();
extern void (*baz_call)();
static int *p;
static void foo ()
{
if (*p != 1)
abort ();
}
int main()
{
int x = 1;
p = &x;
baz_call = foo;
baz ();
return 0;
}
---
void (*baz_call)();
void baz ()
{
baz_call ();
}
and the issue being that escaping foo at baz_call = foo does not escape
foos call uses/clobbers.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
2020-05-05 4:16 ` [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b marxin at gcc dot gnu.org
2020-05-05 6:59 ` rguenth at gcc dot gnu.org
@ 2020-05-05 7:14 ` rguenth at gcc dot gnu.org
2020-05-05 11:04 ` rguenth at gcc dot gnu.org
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-05 7:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
In fact this situation doesn't seem to be handled at all - global variables
are still an afterthought in IPA-PTA it seems. Needs more work than a simple
fix.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (2 preceding siblings ...)
2020-05-05 7:14 ` rguenth at gcc dot gnu.org
@ 2020-05-05 11:04 ` rguenth at gcc dot gnu.org
2020-05-05 11:14 ` rguenth at gcc dot gnu.org
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-05 11:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #3)
> In fact this situation doesn't seem to be handled at all - global variables
> are still an afterthought in IPA-PTA it seems. Needs more work than a
> simple fix.
Hum, actually it's a simple bug and the following fixes it.
diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c
index 416a26c996c..16a2b53c2b7 100644
--- a/gcc/tree-ssa-structalias.c
+++ b/gcc/tree-ssa-structalias.c
@@ -8187,8 +8187,8 @@ ipa_pta_execute (void)
/* For the purpose of IPA PTA unit-local globals are not
escape points. */
- bool nonlocal_p = (var->used_from_other_partition
- || var->externally_visible
+ bool nonlocal_p = (var->externally_visible_p ()
+ || var->used_from_other_partition
|| var->force_output);
var->call_for_symbol_and_aliases (refered_from_nonlocal_var,
&nonlocal_p, true);
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (3 preceding siblings ...)
2020-05-05 11:04 ` rguenth at gcc dot gnu.org
@ 2020-05-05 11:14 ` rguenth at gcc dot gnu.org
2020-05-05 12:41 ` cvs-commit at gcc dot gnu.org
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-05 11:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (4 preceding siblings ...)
2020-05-05 11:14 ` rguenth at gcc dot gnu.org
@ 2020-05-05 12:41 ` cvs-commit at gcc dot gnu.org
2020-05-05 12:45 ` [Bug ipa/94947] [8/9/10 " rguenth at gcc dot gnu.org
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-05 12:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:f9b5db750bc7fbba69fee93564907f7da1bca35f
commit r11-70-gf9b5db750bc7fbba69fee93564907f7da1bca35f
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 5 13:09:50 2020 +0200
ipa/94947 - fix test for externally visible variables for IPA PTA
This fixes lack of an escape point of externally declared variables.
2020-05-05 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (ipa_pta_execute): Use
varpool_node::externally_visible_p ().
(refered_from_nonlocal_var): Likewise.
* gcc.dg/torture/pr94947-1.c: New testcase.
* gcc.dg/torture/pr94947-2.c: Likewise.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (5 preceding siblings ...)
2020-05-05 12:41 ` cvs-commit at gcc dot gnu.org
@ 2020-05-05 12:45 ` rguenth at gcc dot gnu.org
2020-05-07 17:39 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-05 12:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[8/9/10/11 Regression] |[8/9/10 Regression]
|-fipa-pta + pthread_once |-fipa-pta + pthread_once
|crash since |crash since
|r6-5684-g47e5754e17e9ac3b |r6-5684-g47e5754e17e9ac3b
Known to work| |11.0
Known to fail|11.0 |10.0
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (6 preceding siblings ...)
2020-05-05 12:45 ` [Bug ipa/94947] [8/9/10 " rguenth at gcc dot gnu.org
@ 2020-05-07 17:39 ` cvs-commit at gcc dot gnu.org
2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-07 17:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:b9250b3cb91b667cd67943e0fac94bf39ac089a8
commit r11-170-gb9250b3cb91b667cd67943e0fac94bf39ac089a8
Author: Richard Biener <rguenther@suse.de>
Date: Thu May 7 14:06:02 2020 +0200
ipa/94947 - avoid using externally_visible_p ()
externally_visible_p wasn't the correct predicate to use (even if it
worked), instead we should use DECL_EXTERNAL || TREE_PUBLIC.
2020-05-07 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (refered_from_nonlocal_fn): Use
DECL_EXTERNAL || TREE_PUBLIC instead of externally_visible.
(refered_from_nonlocal_var): Likewise.
(ipa_pta_execute): Likewise.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (7 preceding siblings ...)
2020-05-07 17:39 ` cvs-commit at gcc dot gnu.org
@ 2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-13 7:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:67d00c438285ecf9b8e96c12d1f6b05fd2ea3c21
commit r10-8141-g67d00c438285ecf9b8e96c12d1f6b05fd2ea3c21
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 5 13:09:50 2020 +0200
ipa/94947 - fix test for externally visible variables for IPA PTA
This fixes lack of an escape point of externally declared variables.
2020-05-05 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (ipa_pta_execute): Use
varpool_node::externally_visible_p ().
(refered_from_nonlocal_var): Likewise.
* gcc.dg/torture/pr94947-1.c: New testcase.
* gcc.dg/torture/pr94947-2.c: Likewise.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9/10 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (8 preceding siblings ...)
2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
@ 2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
2020-09-11 10:38 ` [Bug ipa/94947] [8/9 " cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-13 7:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:a68d4b47a6b5b23a5d7ab3b358f559f41568512f
commit r10-8142-ga68d4b47a6b5b23a5d7ab3b358f559f41568512f
Author: Richard Biener <rguenther@suse.de>
Date: Thu May 7 14:06:02 2020 +0200
ipa/94947 - avoid using externally_visible_p ()
externally_visible_p wasn't the correct predicate to use (even if it
worked), instead we should use DECL_EXTERNAL || TREE_PUBLIC.
2020-05-07 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (refered_from_nonlocal_fn): Use
DECL_EXTERNAL || TREE_PUBLIC instead of externally_visible.
(refered_from_nonlocal_var): Likewise.
(ipa_pta_execute): Likewise.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (9 preceding siblings ...)
2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
@ 2020-09-11 10:38 ` cvs-commit at gcc dot gnu.org
2020-09-11 10:38 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-11 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:0bcf016768f32799d4dabc82a29440b2ab1d717b
commit r9-8865-g0bcf016768f32799d4dabc82a29440b2ab1d717b
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 5 13:09:50 2020 +0200
ipa/94947 - fix test for externally visible variables for IPA PTA
This fixes lack of an escape point of externally declared variables.
2020-05-05 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (ipa_pta_execute): Use
varpool_node::externally_visible_p ().
(refered_from_nonlocal_var): Likewise.
* gcc.dg/torture/pr94947-1.c: New testcase.
* gcc.dg/torture/pr94947-2.c: Likewise.
(cherry picked from commit f9b5db750bc7fbba69fee93564907f7da1bca35f)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8/9 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (10 preceding siblings ...)
2020-09-11 10:38 ` [Bug ipa/94947] [8/9 " cvs-commit at gcc dot gnu.org
@ 2020-09-11 10:38 ` cvs-commit at gcc dot gnu.org
2020-12-01 14:02 ` [Bug ipa/94947] [8 " cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-11 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:7cfb86a2a18c9d54d1fd43f17affcd184477ecb3
commit r9-8866-g7cfb86a2a18c9d54d1fd43f17affcd184477ecb3
Author: Richard Biener <rguenther@suse.de>
Date: Thu May 7 14:06:02 2020 +0200
ipa/94947 - avoid using externally_visible_p ()
externally_visible_p wasn't the correct predicate to use (even if it
worked), instead we should use DECL_EXTERNAL || TREE_PUBLIC.
2020-05-07 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (refered_from_nonlocal_fn): Use
DECL_EXTERNAL || TREE_PUBLIC instead of externally_visible.
(refered_from_nonlocal_var): Likewise.
(ipa_pta_execute): Likewise.
(cherry picked from commit b9250b3cb91b667cd67943e0fac94bf39ac089a8)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (11 preceding siblings ...)
2020-09-11 10:38 ` cvs-commit at gcc dot gnu.org
@ 2020-12-01 14:02 ` cvs-commit at gcc dot gnu.org
2020-12-01 14:02 ` cvs-commit at gcc dot gnu.org
2020-12-01 14:03 ` rguenth at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-12-01 14:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:1cd95acac5a521937b205ace0db3f1a042561dd8
commit r8-10661-g1cd95acac5a521937b205ace0db3f1a042561dd8
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 5 13:09:50 2020 +0200
ipa/94947 - fix test for externally visible variables for IPA PTA
This fixes lack of an escape point of externally declared variables.
2020-05-05 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (ipa_pta_execute): Use
varpool_node::externally_visible_p ().
(refered_from_nonlocal_var): Likewise.
* gcc.dg/torture/pr94947-1.c: New testcase.
* gcc.dg/torture/pr94947-2.c: Likewise.
(cherry picked from commit f9b5db750bc7fbba69fee93564907f7da1bca35f)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (12 preceding siblings ...)
2020-12-01 14:02 ` [Bug ipa/94947] [8 " cvs-commit at gcc dot gnu.org
@ 2020-12-01 14:02 ` cvs-commit at gcc dot gnu.org
2020-12-01 14:03 ` rguenth at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-12-01 14:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:3114be1ceb750f323a13dad0a419a7622bd71fbe
commit r8-10662-g3114be1ceb750f323a13dad0a419a7622bd71fbe
Author: Richard Biener <rguenther@suse.de>
Date: Thu May 7 14:06:02 2020 +0200
ipa/94947 - avoid using externally_visible_p ()
externally_visible_p wasn't the correct predicate to use (even if it
worked), instead we should use DECL_EXTERNAL || TREE_PUBLIC.
2020-05-07 Richard Biener <rguenther@suse.de>
PR ipa/94947
* tree-ssa-structalias.c (refered_from_nonlocal_fn): Use
DECL_EXTERNAL || TREE_PUBLIC instead of externally_visible.
(refered_from_nonlocal_var): Likewise.
(ipa_pta_execute): Likewise.
(cherry picked from commit b9250b3cb91b667cd67943e0fac94bf39ac089a8)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug ipa/94947] [8 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
` (13 preceding siblings ...)
2020-12-01 14:02 ` cvs-commit at gcc dot gnu.org
@ 2020-12-01 14:03 ` rguenth at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-12-01 14:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94947
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Known to fail| |8.4.0
Known to work| |8.4.1
--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-12-01 14:03 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 22:07 [Bug ipa/94947] New: -fipa-pta + pthread_once crash corydoras at ridiculousfish dot com
2020-05-05 4:16 ` [Bug ipa/94947] [8/9/10/11 Regression] -fipa-pta + pthread_once crash since r6-5684-g47e5754e17e9ac3b marxin at gcc dot gnu.org
2020-05-05 6:59 ` rguenth at gcc dot gnu.org
2020-05-05 7:14 ` rguenth at gcc dot gnu.org
2020-05-05 11:04 ` rguenth at gcc dot gnu.org
2020-05-05 11:14 ` rguenth at gcc dot gnu.org
2020-05-05 12:41 ` cvs-commit at gcc dot gnu.org
2020-05-05 12:45 ` [Bug ipa/94947] [8/9/10 " rguenth at gcc dot gnu.org
2020-05-07 17:39 ` cvs-commit at gcc dot gnu.org
2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
2020-05-13 7:24 ` cvs-commit at gcc dot gnu.org
2020-09-11 10:38 ` [Bug ipa/94947] [8/9 " cvs-commit at gcc dot gnu.org
2020-09-11 10:38 ` cvs-commit at gcc dot gnu.org
2020-12-01 14:02 ` [Bug ipa/94947] [8 " cvs-commit at gcc dot gnu.org
2020-12-01 14:02 ` cvs-commit at gcc dot gnu.org
2020-12-01 14:03 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).