[Bug d/94970] d: internal compiler error: in verify_gimple_stmt, at tree-cfg.c:4959

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94970

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:0af711e1914ab6d88538f1fcf0146757b5608b1d

commit r11-154-g0af711e1914ab6d88538f1fcf0146757b5608b1d
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Wed May 6 23:34:11 2020 +0200

    d: Fix ICE in verify_gimple_stmt, at tree-cfg.c:4959

    Both array concat and array new expressions wrapped any temporaries
    created into a BIND_EXPR.  This does not work if an expression used to
    construct the result requires scope destruction, which is represented by
    a TARGET_EXPR with a clean-up, and a CLEANUP_POINT_EXPR at the
    location where the temporaries logically go out of scope.  The reason
    for this not working is because the lowering of cleanup point
    expressions does not traverse inside BIND_EXPRs to expand any gimple
    cleanup expressions within.

    The use of creating BIND_EXPR has been removed at both locations, and
    replaced with a normal temporary variable that has initialization
    delayed until its address is taken.

    gcc/d/ChangeLog:

            PR d/94970
            * d-codegen.cc (force_target_expr): Move create_temporary_var
            implementation inline here.
            (create_temporary_var): Remove.
            (maybe_temporary_var): Remove.
            (bind_expr): Remove.
            * d-convert.cc (d_array_convert): Use build_local_temp to generate
            temporaries, and generate its assignment.
            * d-tree.h (create_temporary_var): Remove.
            (maybe_temporary_var): Remove.
            (d_array_convert): Remove vars argument.
            * expr.cc (ExprVisitor::visit (CatExp *)): Use build_local_temp to
            generate temporaries, don't wrap them in a BIND_EXPR.
            (ExprVisitor::visit (NewExp *)): Likewise.

    gcc/testsuite/ChangeLog:

            PR d/94970
            * gdc.dg/pr94970.d: New test.