public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/95003] coroutines: Wrong code for some reference capture cases.
Date: Sun, 10 May 2020 15:56:48 +0000	[thread overview]
Message-ID: <bug-95003-4-VbGHENito4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95003-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95003

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:f09d898296c02d023ec51489fd233075ac553fd4

commit r10-8127-gf09d898296c02d023ec51489fd233075ac553fd4
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun May 10 14:20:13 2020 +0100

    coroutines: Update TREE_SIDE_EFFECTS on inserted bind exprs.

    There are several places where we insert bind expressions while
    making the coroutine AST transforms.  These should be marked as
    having side-effects where relevant, which had been omitted.  This
    leads to at least one failure in the cppcoros test suite, where a loop
    body is dropped in gimplification because it is not marked.

    gcc/cp/ChangeLog:

    2020-05-10  Iain Sandoe  <iain@sandoe.co.uk>

            Backported from mainline
            2020-05-08  Iain Sandoe  <iain@sandoe.co.uk>

            PR c++/95003
            * coroutines.cc (build_actor_fn): Ensure that bind scopes
            are marked as having side-effects where necessary.
            (replace_statement_captures): Likewise.
            (morph_fn_to_coro): Likewise.

    gcc/testsuite/ChangeLog:

    2020-05-10  Iain Sandoe  <iain@sandoe.co.uk>

            Backported from mainline
            2020-05-08  Iain Sandoe  <iain@sandoe.co.uk>

            PR c++/95003
            * g++.dg/coroutines/torture/pr95003.C: New test.

  parent reply	other threads:[~2020-05-10 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  9:41 [Bug c++/95003] New: " iains at gcc dot gnu.org
2020-05-08  9:42 ` [Bug c++/95003] " iains at gcc dot gnu.org
2020-05-08 19:47 ` cvs-commit at gcc dot gnu.org
2020-05-09 10:43 ` iains at gcc dot gnu.org
2020-05-10 15:56 ` cvs-commit at gcc dot gnu.org [this message]
2020-05-13 16:56 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95003-4-VbGHENito4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).