* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
@ 2020-05-09 9:39 ` egallager at gcc dot gnu.org
2020-05-09 9:55 ` iains at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: egallager at gcc dot gnu.org @ 2020-05-09 9:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Eric Gallager <egallager at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |egallager at gcc dot gnu.org,
| |iains at gcc dot gnu.org,
| |mikestump at comcast dot net
--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
cc-ing objc++ maintainers
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
2020-05-09 9:39 ` [Bug objc++/95013] " egallager at gcc dot gnu.org
@ 2020-05-09 9:55 ` iains at gcc dot gnu.org
2020-05-10 10:51 ` ro at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: iains at gcc dot gnu.org @ 2020-05-09 9:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
please would you identify the platform(s) and configuration conditions?
I don't see these on at least
x86_64-linux-gnu, powerpc64-linux-gnu (m32, m64)
or on Darwin15, 18, 19 (m32, m64)
at r11-196
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
2020-05-09 9:39 ` [Bug objc++/95013] " egallager at gcc dot gnu.org
2020-05-09 9:55 ` iains at gcc dot gnu.org
@ 2020-05-10 10:51 ` ro at gcc dot gnu.org
2020-05-10 11:43 ` iains at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ro at gcc dot gnu.org @ 2020-05-10 10:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2020-05-10
Target Milestone|--- |11.0
CC| |nathan at gcc dot gnu.org,
| |ro at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Version|10.0 |11.0
--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> ---
I'm seeing them too on both sparc-sun-solaris2.11 and i386-pc-solaris2.11.
My immediate suspicion would be that they are due to Nathan's patch:
[C++] EOF has a location
https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545409.html
Two of the source files (syntax-error-[89].mm lack a newline at EOF), and in
all
cases the message changed from
obj-c++.dg/syntax-error-10.mm:1:1: error: expected identifier at end of input
to
obj-c++.dg/syntax-error-10.mm:1: error: expected identifier at end of input
i.e. the column number got lost.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (2 preceding siblings ...)
2020-05-10 10:51 ` ro at gcc dot gnu.org
@ 2020-05-10 11:43 ` iains at gcc dot gnu.org
2020-05-10 11:46 ` iains at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: iains at gcc dot gnu.org @ 2020-05-10 11:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Iain Sandoe <iains at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |iains at gcc dot gnu.org
--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Rainer Orth from comment #3)
> I'm seeing them too on both sparc-sun-solaris2.11 and i386-pc-solaris2.11.
>
> My immediate suspicion would be that they are due to Nathan's patch:
>
> [C++] EOF has a location
> https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545409.html
>
> Two of the source files (syntax-error-[89].mm lack a newline at EOF), and in
> all
> cases the message changed from
>
> obj-c++.dg/syntax-error-10.mm:1:1: error: expected identifier at end of input
>
> to
>
> obj-c++.dg/syntax-error-10.mm:1: error: expected identifier at end of input
>
> i.e. the column number got lost.
yeah, my tests were just a few revisions before that patch - at r11-235 I see
these on Darwin too, and it seems to be a case for fixing the tests.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (3 preceding siblings ...)
2020-05-10 11:43 ` iains at gcc dot gnu.org
@ 2020-05-10 11:46 ` iains at gcc dot gnu.org
2020-05-11 12:49 ` nathan at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: iains at gcc dot gnu.org @ 2020-05-10 11:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Iain Sandoe <iains at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|iains at gcc dot gnu.org |unassigned at gcc dot gnu.org
--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #4)
> (In reply to Rainer Orth from comment #3)
> > I'm seeing them too on both sparc-sun-solaris2.11 and i386-pc-solaris2.11.
> >
> > My immediate suspicion would be that they are due to Nathan's patch:
> >
> > [C++] EOF has a location
> > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545409.html
> > obj-c++.dg/syntax-error-10.mm:1: error: expected identifier at end of input
> >
> > i.e. the column number got lost.
> yeah, my tests were just a few revisions before that patch - at r11-235 I
> see these on Darwin too, and it seems to be a case for fixing the tests.
hmm maybe that's a diagnostics regression with the dangling colon (without the
colon it would seem reasonable).
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (4 preceding siblings ...)
2020-05-10 11:46 ` iains at gcc dot gnu.org
@ 2020-05-11 12:49 ` nathan at gcc dot gnu.org
2020-05-11 13:05 ` seurer at linux dot vnet.ibm.com
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-05-11 12:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Nathan Sidwell <nathan at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |nathan at gcc dot gnu.org
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug objc++/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (5 preceding siblings ...)
2020-05-11 12:49 ` nathan at gcc dot gnu.org
@ 2020-05-11 13:05 ` seurer at linux dot vnet.ibm.com
2020-05-12 20:40 ` [Bug preprocessor/95013] " cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: seurer at linux dot vnet.ibm.com @ 2020-05-11 13:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Bill Seurer <seurer at linux dot vnet.ibm.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |seurer at linux dot vnet.ibm.com
--- Comment #6 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
These started with r11-204 and occur on powerpc64 BE and LE as well.
commit debfaee5d51e3c07bb88a971618de2baff35d9c0
Author: Nathan Sidwell <nathan@acm.org>
Date: Fri May 8 08:43:16 2020 -0700
EOF has a location
There's no need to special-case EOF's location. For the complete file we
give it a legitimate location. And for deferred parses we now zap a
temporary EOF
onto the next token, so we can just use its location anyway.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug preprocessor/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (6 preceding siblings ...)
2020-05-11 13:05 ` seurer at linux dot vnet.ibm.com
@ 2020-05-12 20:40 ` cvs-commit at gcc dot gnu.org
2020-05-12 20:43 ` nathan at gcc dot gnu.org
2020-05-13 6:43 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-12 20:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:
https://gcc.gnu.org/g:2a0225e47868fbfceaecaa5e2de96c1c5a2251ea
commit r11-338-g2a0225e47868fbfceaecaa5e2de96c1c5a2251ea
Author: Nathan Sidwell <nathan@acm.org>
Date: Tue May 12 13:33:11 2020 -0700
preprocessor: EOF location is at end of file [PR95013]
My recent C++ parser change to pay attention to EOF location uncovered
a separate bug. The preprocesor's EOF logic would set the EOF
location to be the beginning of the last line of text in the file --
not the 'line' after that, which contains no characters. Mostly.
This fixes things so that when we attempt to read the last line of the
main file, we don't pop the buffer until the tokenizer has a chance to
create an EOF token with the correct location information. It is then
responsible for popping the buffer. As it happens, raw string literal
tokenizing contained a bug -- it would increment the line number
prematurely, because it cached buffer->cur in a local variable, but
checked buffer->cur before updating it to figure out if it was at end
of file. We fix up that too.
The EOF token intentionally doesn't have a column number -- it's not a
position on a line, it's a non-existant line.
The testsuite churn is just correcting the EOF location diagnostics.
libcpp/
PR preprocessor/95013
* lex.c (lex_raw_string): Process line notes before incrementing.
Correct incrementing condition. Adjust for new
_cpp_get_fresh_line EOF behaviour.
(_cpp_get_fresh_line): Do not pop buffer at EOF, increment line
instead.
(_cpp_lex_direct): Adjust for new _cpp_get_fresh_line behaviour.
(cpp_directive_only_process): Assert we got a fresh line.
* traditional.c (_cpp_read_logical_line_trad): Adjust for new
_cpp_get_fresh_line behaviour.
gcc/testsuite/
* c-c++-common/goacc/pr79428-1.c: Adjust EOF diagnostic location.
* c-c++-common/gomp/pr79428-2.c: Likewise.
* g++.dg/cpp0x/decltype63.C: Likewise.
* g++.dg/cpp0x/gen-attrs-64.C: Likewise.
* g++.dg/cpp0x/pr68726.C: Likewise.
* g++.dg/cpp0x/pr78341.C: Likewise.
* g++.dg/cpp1y/pr65202.C: Likewise.
* g++.dg/cpp1y/pr65340.C: Likewise.
* g++.dg/cpp1y/pr68578.C: Likewise.
* g++.dg/cpp1z/class-deduction44.C: Likewise.
* g++.dg/diagnostic/unclosed-extern-c.C: Likewise.
* g++.dg/diagnostic/unclosed-function.C: Likewise.
* g++.dg/diagnostic/unclosed-namespace.C: Likewise.
* g++.dg/diagnostic/unclosed-struct.C: Likewise.
* g++.dg/ext/pr84598.C: Likewise.
* g++.dg/other/switch4.C: Likewise.
* g++.dg/parse/attr4.C: Likewise.
* g++.dg/parse/cond4.C: Likewise.
* g++.dg/parse/crash10.C: Likewise.
* g++.dg/parse/crash18.C: Likewise.
* g++.dg/parse/crash27.C: Likewise.
* g++.dg/parse/crash34.C: Likewise.
* g++.dg/parse/crash35.C: Likewise.
* g++.dg/parse/crash52.C: Likewise.
* g++.dg/parse/crash59.C: Likewise.
* g++.dg/parse/crash61.C: Likewise.
* g++.dg/parse/crash67.C: Likewise.
* g++.dg/parse/error14.C: Likewise.
* g++.dg/parse/error56.C: Likewise.
* g++.dg/parse/invalid1.C: Likewise.
* g++.dg/parse/parameter-declaration-1.C: Likewise.
* g++.dg/parse/parser-pr28152-2.C: Likewise.
* g++.dg/parse/parser-pr28152.C: Likewise.
* g++.dg/parse/pr68722.C: Likewise.
* g++.dg/pr46852.C: Likewise.
* g++.dg/pr46868.C: Likewise.
* g++.dg/template/crash115.C: Likewise.
* g++.dg/template/crash43.C: Likewise.
* g++.dg/template/crash90.C: Likewise.
* g++.dg/template/error-recovery1.C: Likewise.
* g++.dg/template/error57.C: Likewise.
* g++.old-deja/g++.other/crash31.C: Likewise.
* gcc.dg/empty-source-2.c: Likewise.
* gcc.dg/empty-source-3.c: Likewise.
* gcc.dg/noncompile/pr30552-3.c: Likewise.
* gcc.dg/noncompile/pr35447-1.c: Likewise.
* gcc.dg/pr20245-1.c: Likewise.
* gcc.dg/pr28419.c: Likewise.
* gcc.dg/rtl/truncated-rtl-file.c: Likewise.
* gcc.dg/unclosed-init.c: Likewise.
* obj-c++.dg/property/property-neg-6.mm: Likewise.
* obj-c++.dg/syntax-error-10.mm: Likewise.
* obj-c++.dg/syntax-error-8.mm: Likewise.
* obj-c++.dg/syntax-error-9.mm: Likewise.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug preprocessor/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (7 preceding siblings ...)
2020-05-12 20:40 ` [Bug preprocessor/95013] " cvs-commit at gcc dot gnu.org
@ 2020-05-12 20:43 ` nathan at gcc dot gnu.org
2020-05-13 6:43 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-05-12 20:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
Nathan Sidwell <nathan at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #8 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
Fixed 2a0225e4786
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug preprocessor/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm
2020-05-08 18:12 [Bug objc++/95013] New: [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm msebor at gcc dot gnu.org
` (8 preceding siblings ...)
2020-05-12 20:43 ` nathan at gcc dot gnu.org
@ 2020-05-13 6:43 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-13 6:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:
https://gcc.gnu.org/g:a7b7818f3dbd14cc7577d25dcebaded07395c476
commit r11-346-ga7b7818f3dbd14cc7577d25dcebaded07395c476
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date: Wed May 13 06:41:19 2020 +0000
[PR 95013] Fix gcc.dg/unclosed-init.c
2020-05-13 Christophe Lyon <christophe.lyon@linaro.org>
PR preprocessor/95013
* gcc.dg/unclosed-init.c: Add missing comment in dg-error.
^ permalink raw reply [flat|nested] 11+ messages in thread