public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/95034] Failure to convert xor pattern (made out of or+and) to xor Date: Tue, 12 Jan 2021 10:33:09 +0000 [thread overview] Message-ID: <bug-95034-4-vqB4eCfmC6@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95034-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95034 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> --- For int combine (int a, int b) { return (a | b) & ~(a & b); } we do optimize it, for the ||s and &&s the problem is that it is split accross multiple basic blocks, so match.pd is out of the picture, but on the other side reassoc which can handle conditions split across multiple bbs will handle only a single truth operation (so the && in this case) and so we'd need to look through the |s from there manually. Ah, an option could be to add some truth_{and,ior,*} rules in match.pd, limited to GENERIC probably, as it won't trigger afterwards. But of course that would handle only the above testcase and not e.g. bool t1 = a || b; bool t2 = !(a && b); return t1 && t2; etc. Richard, any ideas?
next prev parent reply other threads:[~2021-01-12 10:33 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-10 9:48 [Bug tree-optimization/95034] New: Pattern for xor not converted " gabravier at gmail dot com 2020-05-13 12:38 ` [Bug tree-optimization/95034] Failure to convert xor pattern (made out of or+and) " pinskia at gcc dot gnu.org 2021-01-12 10:33 ` jakub at gcc dot gnu.org [this message] 2021-01-12 10:56 ` jakub at gcc dot gnu.org 2021-01-12 11:03 ` jakub at gcc dot gnu.org 2021-01-12 12:12 ` jakub at gcc dot gnu.org 2021-04-17 21:03 ` pinskia at gcc dot gnu.org 2023-08-23 2:16 ` pinskia at gcc dot gnu.org 2023-10-17 4:39 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95034-4-vqB4eCfmC6@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).