[Bug other/95058] New: [11 regression] vector test case failures starting with r11-205

[Bug other/95058] New: [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

            Bug ID: 95058
           Summary: [11 regression] vector test case failures starting
                    with r11-205
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at linux dot vnet.ibm.com
  Target Milestone: ---

this run    : g:bc484e250990393e887f7239157cc85ce6fadcce, r11-205:

This occurs on all powerpc 64 targets:

FAIL: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects 
scan-tree-dump-times slp2 "Basic block will be vectorized" 1
FAIL: gcc.dg/vect/bb-slp-pr68892.c scan-tree-dump-times slp2 "Basic block will
be vectorized" 1


This one only occurs on power 7 BE:

FAIL: gcc.dg/vect/bb-slp-pr69907.c -flto -ffat-lto-objects  scan-tree-dump slp1
"BB vectorization with gaps at the end of a load is not supported"
FAIL: gcc.dg/vect/bb-slp-pr69907.c scan-tree-dump slp1 "BB vectorization with
gaps at the end of a load is not supported"

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
          Component|other                       |tree-optimization

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Can you attach the dumps for power7 and "the rest"?

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #2 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
PASS: gcc.dg/vect/bb-slp-pr68892.c (test for excess errors)
XPASS: gcc.dg/vect/bb-slp-pr68892.c scan-tree-dump slp2 "not profitable"
PASS: gcc.dg/vect/bb-slp-pr68892.c scan-tree-dump-times slp2 "BB vectorization
with gaps at the end of a load is not supported" 1
gcc.dg/vect/bb-slp-pr68892.c: pattern found 0 times
FAIL: gcc.dg/vect/bb-slp-pr68892.c scan-tree-dump-times slp2 "Basic block will
be vectorized" 1
Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/vect/bb-slp-pr68892.c   
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never  -fdiagnostics-urls=never  -flto -ffat-lto-objects
-maltivec -mvsx -mno-allow-movmisalign -ftree-vectorize
-fno-tree-loop-distribute-patterns -fno-vect-cost-model -fno-common -O2
-fdump-tree-slp-details -fvect-cost-model=dynamic -S -o bb-slp-pr68892.s   
(timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/vect/bb-slp-pr68892.c
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -fdiagnostics-urls=never -flto -ffat-lto-objects
-maltivec -mvsx -mno-allow-movmisalign -ftree-vectorize
-fno-tree-loop-distribute-patterns -fno-vect-cost-model -fno-common -O2
-fdump-tree-slp-details -fvect-cost-model=dynamic -S -o bb-slp-pr68892.s
PASS: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects (test for excess
errors)
XPASS: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects  scan-tree-dump
slp2 "not profitable"
PASS: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects 
scan-tree-dump-times slp2 "BB vectorization with gaps at the end of a load is
not supported" 1
gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects : pattern found 0 times
FAIL: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects 
scan-tree-dump-times slp2 "Basic block will be vectorized" 1

Output files from last compile command attached.

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #3 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
Created attachment 48508
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48508&action=edit
dump file

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #4 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
And for the power 7 specific one (the other one also occurs on power 7)

Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/vect/bb-slp-pr69907.c   
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never  -fdiagnostics-urls=never  -flto -ffat-lto-objects
-maltivec -mvsx -mno-allow-movmisalign -ftree-vectorize
-fno-tree-loop-distribute-patterns -fno-vect-cost-model -fno-common -O2
-fdump-tree-slp-details -O3 -S -o bb-slp-pr69907.s    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/vect/bb-slp-pr69907.c
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -fdiagnostics-urls=never -flto -ffat-lto-objects
-maltivec -mvsx -mno-allow-movmisalign -ftree-vectorize
-fno-tree-loop-distribute-patterns -fno-vect-cost-model -fno-common -O2
-fdump-tree-slp-details -O3 -S -o bb-slp-pr69907.s
PASS: gcc.dg/vect/bb-slp-pr69907.c -flto -ffat-lto-objects (test for excess
errors)
FAIL: gcc.dg/vect/bb-slp-pr69907.c -flto -ffat-lto-objects  scan-tree-dump slp1
"BB vectorization with gaps at the end of a load is not supported"

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #5 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
Created attachment 48509
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48509&action=edit
dump file p7 specific

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-05-12

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
OK, so for non 7 BE we end up not vectorizing because it doesn't look
profitable
which IMHO is good.  It would be nice to also see dumps before the respective
rev. because in theory (well...) the cost computation should be the same.
Ah!  OK, so we now have

0x10002001470 _1 1 times vec_construct costs 2 in prologue
0x10002001470 _1 1 times vec_construct costs 2 in prologue
0x10002001470 _1 2 times vector_store costs 2 in body
0x10001ecfcc0 _1 1 times scalar_store costs 1 in body
0x10001ecfcc0 _2 1 times scalar_store costs 1 in body
0x10001ecfcc0 _3 1 times scalar_store costs 1 in body
0x10001ecfcc0 _4 1 times scalar_store costs 1 in body

that is, the SLP graph has the expected cost.  Originally we likely
had costed against 4 scalar stores and 4 scalar loads (but the scalar
loads will still be there).  On x86_64 we get

0x3975280 _1 1 times vec_construct costs 8 in prologue
0x3975280 _1 1 times vec_construct costs 8 in prologue
0x3975280 _1 2 times vector_store costs 24 in body
0x3942cb0 _1 1 times scalar_store costs 12 in body
0x3942cb0 _2 1 times scalar_store costs 12 in body
0x3942cb0 _3 1 times scalar_store costs 12 in body
0x3942cb0 _4 1 times scalar_store costs 12 in body

so it's still profitable there.

Note I suggest to leave the FAILs in place for now since in my dev tree
I see the vec_construct gone again so it would start passing again
on ppc as well.

Sorry for the intermediate breakage.

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 95266 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Can you check if the FAILs still occur after
g:dc0c0196340f7ac58b10d0042d7cea776d6f7864

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #9 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
It looks good in a test I just ran.

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

--- Comment #10 from Bill Seurer <seurer at linux dot vnet.ibm.com> ---
There is still one that is failing:

make -k check-gcc RUNTESTFLAGS=vect.exp=gcc.dg/vect/bb-slp-pr68892.c

XPASS: gcc.dg/vect/bb-slp-pr68892.c scan-tree-dump slp2 "not profitable"
XPASS: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects  scan-tree-dump
slp2 "not profitable"
FAIL: gcc.dg/vect/bb-slp-pr68892.c scan-tree-dump-times slp2 "Basic block will
be vectorized" 1
FAIL: gcc.dg/vect/bb-slp-pr68892.c -flto -ffat-lto-objects 
scan-tree-dump-times slp2 "Basic block will be vectorized" 1

# of expected passes            4
# of unexpected failures        2

[Bug tree-optimization/95058] [11 regression] vector test case failures starting with r11-205

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95058

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Tracking the last one in PR96098