[Bug d/95075] New: gcc/d/dmd/dscope.c: 2 * strange assignments ?

[Bug d/95075] New: gcc/d/dmd/dscope.c: 2 * strange assignments ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95075

            Bug ID: 95075
           Summary: gcc/d/dmd/dscope.c: 2 * strange assignments ?
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I just tried to build the D compiler with the clang++ compiler.

1.

trunk.git/gcc/d/dmd/dscope.c:318:23: warning: explicitly assigning value of
variable of type 'unsigned int' to itself [-Wself-assign]

Source code is

         fieldInit = fieldInit;

2.

trunk.git/gcc/d/dmd/dscope.c:328:23: warning: explicitly assigning value of
variable of type 'unsigned int' to itself [-Wself-assign]

Duplicate.

[Bug d/95075] gcc/d/dmd/dscope.c: 2 * strange assignments ?

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95075

--- Comment #1 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Also present in upstream implementation, I'll ask the author of the change
about it.

[Bug d/95075] gcc/d/dmd/dscope.c: 2 * strange assignments ?

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95075

--- Comment #2 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
"""
I think I wrote it that way to emphasize what the result should be, and relied
on the optimizer removing the self-assignment. So, the code is correct.
"""

So I'll remove the self-assignment with a comment expressing this instead.

[Bug d/95075] gcc/d/dmd/dscope.c: 2 * strange assignments ?

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95075

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:1b7b352a8379dbdd74c962d11951982e21e20f13

commit r11-1662-g1b7b352a8379dbdd74c962d11951982e21e20f13
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Wed Jun 24 08:35:58 2020 +0200

    d: Merge upstream dmd 4be011355.

    Fixes self-assignment warnings seen when compiling with clang.

    Reviewed-on: https://github.com/dlang/dmd/pull/11315

    gcc/d/ChangeLog:

            PR d/95075
            * dmd/MERGE: Merge upstream dmd 4be011355.

[Bug d/95075] gcc/d/dmd/dscope.c: 2 * strange assignments ?

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95075

Iain Buclaw <ibuclaw at gdcproject dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Done.