public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ville.voutilainen at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/95111] coroutines use-after-free with lambdas
Date: Thu, 14 May 2020 11:59:01 +0000	[thread overview]
Message-ID: <bug-95111-4-R3oRHnPhhj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95111-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95111

--- Comment #17 from Ville Voutilainen <ville.voutilainen at gmail dot com> ---
(In reply to Ville Voutilainen from comment #16)
> (In reply to Iain Sandoe from comment #14)
> > (In reply to Ville Voutilainen from comment #12)
> > The idea of bringing the lambda's captures into the coro frame was what I
> > originally implemented.  Richard pointed out that this is wrong when the
> > lambda is mutable (see
> > gcc/testsuite/g++.dg/coroutines/torture/lambda-10-mutable.C)
> > 
> > so if one has
> > 
> > auto X = [...] () -> some_coro<xxx> {};
> > 
> > X must exist for the duration of the lambda coro [it was pointed out by
> > Lewis that really this is only the same as saying that if you have a class
> > with a member function lambda, the instance of that class has to persist for
> > the duration of the coro].
> 
> Ah. So the work-around for this problem is to copy the capture to a local
> variable, and co_return that; then the local variable is in the coro-state.
> Right?

That is, instead of writing

[x] {co_return x;}

write

[x] {auto xx = x; co_return xx;}

  parent reply	other threads:[~2020-05-14 11:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 17:36 [Bug c++/95111] New: " avi@cloudius-systems.com
2020-05-13 19:12 ` [Bug c++/95111] " iains at gcc dot gnu.org
2020-05-13 19:14 ` avi@cloudius-systems.com
2020-05-13 19:15 ` avi@cloudius-systems.com
2020-05-13 19:21 ` iains at gcc dot gnu.org
2020-05-13 19:27 ` avi@cloudius-systems.com
2020-05-13 19:39 ` iains at gcc dot gnu.org
2020-05-13 20:10 ` avi@cloudius-systems.com
2020-05-13 20:11 ` avi@cloudius-systems.com
2020-05-13 20:17 ` iains at gcc dot gnu.org
2020-05-13 20:24 ` avi@cloudius-systems.com
2020-05-14 11:15 ` avi@cloudius-systems.com
2020-05-14 11:24 ` ville.voutilainen at gmail dot com
2020-05-14 11:29 ` avi@cloudius-systems.com
2020-05-14 11:46 ` iains at gcc dot gnu.org
2020-05-14 11:54 ` avi@cloudius-systems.com
2020-05-14 11:57 ` ville.voutilainen at gmail dot com
2020-05-14 11:59 ` ville.voutilainen at gmail dot com [this message]
2020-05-14 12:01 ` avi@cloudius-systems.com
2020-05-14 12:02 ` iains at gcc dot gnu.org
2020-05-14 12:02 ` avi@cloudius-systems.com
2020-05-14 12:25 ` iains at gcc dot gnu.org
2020-05-14 12:33 ` avi@cloudius-systems.com
2020-05-14 12:34 ` avi@cloudius-systems.com
2020-05-14 18:02 ` egallager at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95111-4-R3oRHnPhhj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).