public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/95237] LOCAL_DECL_ALIGNMENT shrinks alignment, FAIL gcc.target/i386/pr69454-2.c
Date: Mon, 01 Jun 2020 08:38:47 +0000 [thread overview]
Message-ID: <bug-95237-4-96lP0KsNDV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95237-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95237
--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
ICEs are "fixed" by the first hunk, the testcase in Comment #0 by the second:
--cut here--
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 060e2df62ea..cd7abaf7e04 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -16752,6 +16752,7 @@ ix86_local_alignment (tree exp, machine_mode mode,
decl = NULL;
}
+#if 0
/* Don't do dynamic stack realignment for long long objects with
-mpreferred-stack-boundary=2. */
if (!TARGET_64BIT
@@ -16761,6 +16762,7 @@ ix86_local_alignment (tree exp, machine_mode mode,
&& (!type || !TYPE_USER_ALIGN (type))
&& (!decl || !DECL_USER_ALIGN (decl)))
align = 32;
+#endif
/* If TYPE is NULL, we are allocating a stack slot for caller-save
register in MODE. We will return the largest alignment of XF
@@ -16868,6 +16870,7 @@ ix86_minimum_alignment (tree exp, machine_mode mode,
if (TARGET_64BIT || align != 64 || ix86_preferred_stack_boundary >= 64)
return align;
+#if 0
/* Don't do dynamic stack realignment for long long objects with
-mpreferred-stack-boundary=2. */
if ((mode == DImode || (type && TYPE_MODE (type) == DImode))
@@ -16877,6 +16880,7 @@ ix86_minimum_alignment (tree exp, machine_mode mode,
gcc_checking_assert (!TARGET_STV);
return 32;
}
+#endif
return align;
}
--cut here--
next prev parent reply other threads:[~2020-06-01 8:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 12:58 [Bug target/95237] New: " rguenth at gcc dot gnu.org
2020-05-20 15:34 ` [Bug target/95237] " hjl.tools at gmail dot com
2020-05-28 7:36 ` rguenth at gcc dot gnu.org
2020-06-01 8:38 ` ubizjak at gmail dot com [this message]
2020-06-01 20:47 ` skpgkp2 at gmail dot com
2020-06-01 21:24 ` hjl.tools at gmail dot com
2020-06-02 3:31 ` kito at gcc dot gnu.org
2020-06-02 7:53 ` rguenth at gcc dot gnu.org
2020-06-02 11:06 ` hjl.tools at gmail dot com
2020-06-02 12:00 ` rguenther at suse dot de
2020-06-02 12:55 ` hjl.tools at gmail dot com
2020-06-02 13:07 ` rguenther at suse dot de
2020-06-02 13:18 ` hjl.tools at gmail dot com
2020-06-02 13:35 ` rguenther at suse dot de
2020-06-02 16:55 ` skpgkp2 at gmail dot com
2020-06-02 17:52 ` rguenther at suse dot de
2020-06-11 17:09 ` jakub at gcc dot gnu.org
2020-06-19 17:40 ` skpgkp2 at gmail dot com
2020-06-20 0:36 ` skpgkp2 at gmail dot com
2020-06-26 13:47 ` jakub at gcc dot gnu.org
2020-07-20 13:05 ` dcb314 at hotmail dot com
2020-07-21 23:30 ` cvs-commit at gcc dot gnu.org
2020-07-21 23:30 ` hjl.tools at gmail dot com
2020-07-22 6:34 ` skpgkp2 at gmail dot com
2020-07-22 14:41 ` cvs-commit at gcc dot gnu.org
2020-07-24 21:19 ` cvs-commit at gcc dot gnu.org
2020-07-24 21:20 ` hjl.tools at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-95237-4-96lP0KsNDV@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).