[Bug bootstrap/95244] New: GCC 10 no longer builds on RHEL5 [trivial patch]

[Bug bootstrap/95244] New: GCC 10 no longer builds on RHEL5 [trivial patch]

[lopresti at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

            Bug ID: 95244
           Summary: GCC 10 no longer builds on RHEL5 [trivial patch]
           Product: gcc
           Version: 10.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lopresti at gmail dot com
  Target Milestone: ---

I still compile GCC on Red Hat Enterprise Linux 5. It is an EoL platform, so
maybe you do not care... But the only problem (introduced with GCC 10) is the
lack of O_CLOEXEC. The following patch fixes my build:

diff --git a/libsanitizer/sanitizer_common/sanitizer_posix.cpp
b/libsanitizer/sanitizer_common/sanitizer_posix.cpp
index d890a3a3177..6ba525d1811 100644
--- a/libsanitizer/sanitizer_common/sanitizer_posix.cpp
+++ b/libsanitizer/sanitizer_common/sanitizer_posix.cpp
@@ -347,8 +347,14 @@ int GetNamedMappingFd(const char *name, uptr size, int
*flags) {
   CHECK(internal_strlen(name) < sizeof(shmname) - 10);
   internal_snprintf(shmname, sizeof(shmname), "/dev/shm/%zu [%s]",
                     internal_getpid(), name);
+#if defined O_CLOEXEC
   int fd = ReserveStandardFds(
       internal_open(shmname, O_RDWR | O_CREAT | O_TRUNC | O_CLOEXEC,
S_IRWXU));
+#else
+  int fd = ReserveStandardFds(
+      internal_open(shmname, O_RDWR | O_CREAT | O_TRUNC, S_IRWXU));
+  fcntl(fd, F_SETFD, FD_CLOEXEC);
+#endif

I would be happy to make this a pull request if there is any chance it would
get accepted. Thanks.

[Bug sanitizer/95244] GCC 10 no longer builds on RHEL5 [trivial patch]

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-05-21
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Thank you for the report.
Please make a patch submission to upstream project:
https://reviews.llvm.org/

We sync the runtime library from LLVM.

[Bug sanitizer/95244] GCC 10 no longer builds on RHEL5 [trivial patch]

[lopresti at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

--- Comment #2 from Patrick J. LoPresti <lopresti at gmail dot com> ---
Done (https://github.com/google/sanitizers/issues/1253). Thanks.

[Bug sanitizer/95244] GCC 10 no longer builds on RHEL5 [trivial patch]

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

nightstrike <nightstrike at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nightstrike at gmail dot com

--- Comment #3 from nightstrike <nightstrike at gmail dot com> ---
That link leads to:

https://reviews.llvm.org/D80648

Which was approved, and eventually merged into gcc here at 3c6331c2 and later
improved with 0b997f6e.

This can be marked as a regression fixed in 11.1 but still in 10 as of 10.3.

[Bug sanitizer/95244] [10 Regression] GCC 10 no longer builds on RHEL5 [trivial patch]

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.4
            Summary|GCC 10 no longer builds on  |[10 Regression] GCC 10 no
                   |RHEL5 [trivial patch]       |longer builds on RHEL5
                   |                            |[trivial patch]

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed in GCC 11 by a merge from upstream; r11-781.

[Bug sanitizer/95244] [10 Regression] GCC 10 no longer builds on RHEL5 [trivial patch]

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug sanitizer/95244] [10 Regression] GCC 10 no longer builds on RHEL5 [trivial patch]

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95244

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Known to work|                            |11.0
   Target Milestone|10.5                        |11.0
      Known to fail|                            |10.5.0
             Status|NEW                         |RESOLVED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed in GCC 11.