public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/95260] New: Confusing comments in cpuid.h
@ 2020-05-21 14:13 hjl.tools at gmail dot com
2020-05-21 14:25 ` [Bug target/95260] " marxin at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2020-05-21 14:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95260
Bug ID: 95260
Summary: Confusing comments in cpuid.h
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: hjl.tools at gmail dot com
Target Milestone: ---
Target: i386, x86-64
cpuid.h has
/* XFEATURE_ENABLED_MASK register bits (%eax == 13, %ecx == 0) */
^^^ This is decimal.
/* Extended State Enumeration Sub-leaf (%eax == 13, %ecx == 1) */
^^^ This is decimal.
/* PT sub leaf (%eax == 14, %ecx == 0) */
^^^ This is hex.
Since Intel SDM uses hex, comments should use hex eveywhere.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/95260] Confusing comments in cpuid.h
2020-05-21 14:13 [Bug target/95260] New: Confusing comments in cpuid.h hjl.tools at gmail dot com
@ 2020-05-21 14:25 ` marxin at gcc dot gnu.org
2020-05-21 14:30 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-05-21 14:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95260
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Just a question: why do you create PRs for all these issues?
Is it because you want to backport fixes to active branches?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/95260] Confusing comments in cpuid.h
2020-05-21 14:13 [Bug target/95260] New: Confusing comments in cpuid.h hjl.tools at gmail dot com
2020-05-21 14:25 ` [Bug target/95260] " marxin at gcc dot gnu.org
@ 2020-05-21 14:30 ` cvs-commit at gcc dot gnu.org
2020-05-21 14:53 ` hjl.tools at gmail dot com
2020-05-21 14:54 ` hjl.tools at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-21 14:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95260
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:
https://gcc.gnu.org/g:a74630f3207d0bec63710c8c803685a0a4956986
commit r11-552-ga74630f3207d0bec63710c8c803685a0a4956986
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Thu May 21 07:19:27 2020 -0700
config/i386/cpuid.h: Use hexadecimal in comments
Since Intel SDM uses hexadecimal, use hexadecimal in comments.
PR target/95260
* config/i386/cpuid.h: Use hexadecimal in comments.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/95260] Confusing comments in cpuid.h
2020-05-21 14:13 [Bug target/95260] New: Confusing comments in cpuid.h hjl.tools at gmail dot com
2020-05-21 14:25 ` [Bug target/95260] " marxin at gcc dot gnu.org
2020-05-21 14:30 ` cvs-commit at gcc dot gnu.org
@ 2020-05-21 14:53 ` hjl.tools at gmail dot com
2020-05-21 14:54 ` hjl.tools at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2020-05-21 14:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95260
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |11.0
--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 11.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/95260] Confusing comments in cpuid.h
2020-05-21 14:13 [Bug target/95260] New: Confusing comments in cpuid.h hjl.tools at gmail dot com
` (2 preceding siblings ...)
2020-05-21 14:53 ` hjl.tools at gmail dot com
@ 2020-05-21 14:54 ` hjl.tools at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2020-05-21 14:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95260
--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Martin Liška from comment #1)
> Just a question: why do you create PRs for all these issues?
> Is it because you want to backport fixes to active branches?
That would be nice.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-21 14:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 14:13 [Bug target/95260] New: Confusing comments in cpuid.h hjl.tools at gmail dot com
2020-05-21 14:25 ` [Bug target/95260] " marxin at gcc dot gnu.org
2020-05-21 14:30 ` cvs-commit at gcc dot gnu.org
2020-05-21 14:53 ` hjl.tools at gmail dot com
2020-05-21 14:54 ` hjl.tools at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).