public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/95264] Infinite Loop When Compiling Templated C++ code at -O1 and above
Date: Fri, 22 May 2020 11:34:15 +0000 [thread overview]
Message-ID: <bug-95264-4-CqXbcKqx9F@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95264-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95264
--- Comment #7 from rguenther at suse dot de <rguenther at suse dot de> ---
On Fri, 22 May 2020, freddie at witherden dot org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95264
>
> --- Comment #6 from Freddie Witherden <freddie at witherden dot org> ---
> (In reply to Richard Biener from comment #3)
> > So with the [[gnu::flatten]] attributes removed -O1 needs 80 seconds to
> > compile and about 3GB of memory, -O2 needs around 2 minutes (same memory),
> > -O3
> > is the same as -O2.
> >
> > Maybe instead of [[gnu::flatten]] you want to bump --param inline-unit-growth
> > or --param large-function-growth more moderately in case you can measure an
> > effect on runtime.
> >
> > Note multiple [[gnu::flatten]] can really exponentially grow program size
> > since it is not appearant which functions might be used from another
> > translation unit until you can use -fwhole-program (single CU program)
> > or -flto (but there [[gnu::flatten]] is applied to early to avoid such
> > growth - sth we might want to fix). Placing things not used from outside
> > in anonymous namespaces might help.
>
> The [[gnu::flatten]] was added to get GCC's performance in the case of T =
> double on a par with Clang's. (We don't care about performance with T = bfloat
> as it is just used as a final polishing pass.) I can understand why GCC does
> not want to inline it in the case of T = bfloat which is a complex type, but
> for T = double the function is basically just a sequence of mov's to populate
> an array.
>
> As the function is of the form
>
> for (int i = 0; i < N; i++) // N = template arg
> for (int j = 0; j < p[N]; j++) // runtime trip count
> foo(i, ...); // static polymorphism
>
> with foo being a large switch-case on its first argument the expectation was
> for the compiler to inline foo, unroll the outer loop, and then prune the dead
> cases such that we have something similar to
>
> for (int j = 0; j < p[0]; j++)
> foo(0, ...); // inline i = 0 case
> for (int j = 0; j < p[1]; j++)
> foo(1, ...); // inline i = 1 case
> // ...
Ah, interesting. This kind of static polymorphism should be handled
by IPA-CP already but it's of course possible we're confused about
a detail in this very testcase. Honza?
Instead of [[gnu::flatten]] you could use the
__attribute__((always_inline)) attribute on the foo function definition
if you didn't simplify the outline above too much to make that
infeasible. IIRC we do not have sth like
[[gnu::inline]] foo(i, ...);
to force inlining of a specific call, nor [[gnu::noinline]] foo(i, ...);
both which seem useful. Not sure if the C++ syntax would support
such placement of an attribute of course.
next prev parent reply other threads:[~2020-05-22 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 22:08 [Bug c++/95264] New: " freddie at witherden dot org
2020-05-22 9:14 ` [Bug c++/95264] " rguenth at gcc dot gnu.org
2020-05-22 9:35 ` rguenth at gcc dot gnu.org
2020-05-22 9:44 ` rguenth at gcc dot gnu.org
2020-05-22 9:55 ` rguenth at gcc dot gnu.org
2020-05-22 10:19 ` rguenth at gcc dot gnu.org
2020-05-22 11:13 ` freddie at witherden dot org
2020-05-22 11:34 ` rguenther at suse dot de [this message]
2020-05-22 11:49 ` freddie at witherden dot org
2021-10-02 6:00 ` [Bug ipa/95264] " pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-95264-4-CqXbcKqx9F@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).