public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/95304] New: Clean up some code for finalization
@ 2020-05-24 12:01 tkoenig at gcc dot gnu.org
  2020-05-24 12:02 ` [Bug fortran/95304] " tkoenig at gcc dot gnu.org
  2021-02-14 18:37 ` dominiq at lps dot ens.fr
  0 siblings, 2 replies; 3+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-05-24 12:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95304

            Bug ID: 95304
           Summary: Clean up some code for finalization
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tkoenig at gcc dot gnu.org
  Target Milestone: ---

Just looked at the output of 

gfortran -fdump-fortran-original finalize_28.f90

which has

   symtree: 'idx2'        || symbol: 'idx2'         
      type spec : (INTEGER 8)
      attributes: (VARIABLE  ARTIFICIAL)
    symtree: 'ignore'      || symbol: 'ignore'       
      type spec : (INTEGER 4)
      attributes: (VARIABLE  ARTIFICIAL)
    symtree: 'is_contiguous'|| symbol: 'is_contiguous' 
      type spec : (LOGICAL 4)
      attributes: (VARIABLE  ARTIFICIAL)
    symtree: 'nelem'       || symbol: 'nelem'

[...]

    DO __final_coo_graphs_Coo_graph:idx=1_8
__convert_i4_i8[[((_F.rank[[((__final_coo_graphs_Coo_graph:array(FULL)))]]))]]
1_8
      ASSIGN
__final_coo_graphs_Coo_graph:strides(__final_coo_graphs_Coo_graph:idx)
_F.stride[[((__final_coo_graphs_Coo_graph:array(FULL))
(__final_coo_graphs_Coo_graph:idx))]]
      ASSIGN
__final_coo_graphs_Coo_graph:sizes(__final_coo_graphs_Coo_graph:idx) (*
__final_coo_graphs_Coo_graph:sizes((- __final_coo_graphs_Coo_graph:idx 1_8))
_F.size[[((__final_coo_graphs_Coo_graph:array(FULL))
(__final_coo_graphs_Coo_graph:idx) (8_8))]])
      IF (/=
__final_coo_graphs_Coo_graph:strides(__final_coo_graphs_Coo_graph:idx)
__final_coo_graphs_Coo_graph:sizes((- __final_coo_graphs_Coo_graph:idx 1_8)))
        ASSIGN __final_coo_graphs_Coo_graph:is_contiguous .false.
      ENDIF
    END DO

We should be able to use the is_contiguous intrinsic and also
use variable names which are prefixed with __ so we can not collide
with user variables under any circumstances.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug fortran/95304] Clean up some code for finalization
  2020-05-24 12:01 [Bug fortran/95304] New: Clean up some code for finalization tkoenig at gcc dot gnu.org
@ 2020-05-24 12:02 ` tkoenig at gcc dot gnu.org
  2021-02-14 18:37 ` dominiq at lps dot ens.fr
  1 sibling, 0 replies; 3+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-05-24 12:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95304

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug fortran/95304] Clean up some code for finalization
  2020-05-24 12:01 [Bug fortran/95304] New: Clean up some code for finalization tkoenig at gcc dot gnu.org
  2020-05-24 12:02 ` [Bug fortran/95304] " tkoenig at gcc dot gnu.org
@ 2021-02-14 18:37 ` dominiq at lps dot ens.fr
  1 sibling, 0 replies; 3+ messages in thread
From: dominiq at lps dot ens.fr @ 2021-02-14 18:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95304

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-02-14
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
What cleanup do you expect?

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-14 18:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 12:01 [Bug fortran/95304] New: Clean up some code for finalization tkoenig at gcc dot gnu.org
2020-05-24 12:02 ` [Bug fortran/95304] " tkoenig at gcc dot gnu.org
2021-02-14 18:37 ` dominiq at lps dot ens.fr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).