public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/95322] std::list | take | transform, expression does not work cbegin() == end()
Date: Wed, 27 May 2020 21:08:23 +0000 [thread overview]
Message-ID: <bug-95322-4-AGNyfS4DU3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95322-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95322
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:6c2582c0406250c66e2eb3651f8e8638796b7f53
commit r11-673-g6c2582c0406250c66e2eb3651f8e8638796b7f53
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed May 27 22:08:15 2020 +0100
libstdc++: Fix view adaptors for mixed-const sentinels and iterators (PR
95322)
The bug report is that transform_view's sentinel<false> cannot be
compared to its iterator<true>. The comparison is supposed to use
operator==(iterator<Const>, sentinel<Const>) after converting
sentinel<false> to sentinel<true>. However, the operator== is a hidden
friend so is not a candidate when comparing iterator<true> with
sentinel<false>. The required conversion would only happen if we'd found
the operator, but we can't find the operator until after the conversion
happens.
A new LWG issue has been reported, but not yet assigned a number. The
solution suggested by Casey Carter is to make the hidden friends of the
sentinel types work with iterators of any const-ness, so that no
conversions are required.
Patrick Palka observed that join_view has a similar problem and a
similar fix is used for its sentinel.
PR libstdc++/95322
* include/std/ranges (transform_view::_Sentinel): Allow hidden
friends to work with _Iterator<true> and _Iterator<false>.
(join_view::_Sentinel): Likewise.
* testsuite/std/ranges/adaptors/95322.cc: New test.
next prev parent reply other threads:[~2020-05-27 21:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:16 [Bug libstdc++/95322] New: " gcc-bugs at marehr dot dialup.fu-berlin.de
2020-05-26 13:13 ` [Bug libstdc++/95322] " redi at gcc dot gnu.org
2020-05-26 13:18 ` redi at gcc dot gnu.org
2020-05-26 13:21 ` redi at gcc dot gnu.org
2020-05-26 13:54 ` ppalka at gcc dot gnu.org
2020-05-26 20:45 ` cvs-commit at gcc dot gnu.org
2020-05-27 20:00 ` redi at gcc dot gnu.org
2020-05-27 20:04 ` daniel.kruegler at googlemail dot com
2020-05-27 20:29 ` redi at gcc dot gnu.org
2020-05-27 21:08 ` cvs-commit at gcc dot gnu.org [this message]
2020-05-27 21:11 ` redi at gcc dot gnu.org
2020-05-28 1:48 ` cvs-commit at gcc dot gnu.org
2020-05-28 18:51 ` daniel.kruegler at googlemail dot com
2020-07-09 12:59 ` cvs-commit at gcc dot gnu.org
2020-07-09 14:51 ` redi at gcc dot gnu.org
2020-07-09 17:54 ` gcc-bugs at marehr dot dialup.fu-berlin.de
2020-08-27 1:53 ` cvs-commit at gcc dot gnu.org
2020-10-12 17:48 ` cvs-commit at gcc dot gnu.org
2020-10-21 1:57 ` cvs-commit at gcc dot gnu.org
2020-12-01 16:20 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-95322-4-AGNyfS4DU3@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).