From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1DEF2383F862; Wed, 27 May 2020 01:47:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DEF2383F862 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1590544042; bh=2BI10tCk8h0CanW5I8VIuLDhtjiOiOl0wWcs4rp+E1o=; h=From:To:Subject:Date:In-Reply-To:References:From; b=lvbI7+tmu5u9lz8/n58Gu1YLrfrDKlZEfLeIrx8Ee5Px7l9i0MJ4iy9DkCKI47q17 uoSmc9ZzXBVP/ti/ydj9VpQzMdau5DXcVTAaUJX0lCXer1DddwPAjfVxw3fyQ7cqhq fqLxqtnetNrw/+WwfAcDJVKlCsVm5pGRw2HFvCy4= From: "dongjianqiang2 at huawei dot com" To: gcc-bugs@gcc.gnu.org Subject: =?UTF-8?B?W0J1ZyBnY292LXByb2ZpbGUvOTUzMzJdIGdjb3YtdG9vbCBtZXJn?= =?UTF-8?B?Ze+8miJub3QgYSBnY292IGRhdGEgZmlsZSI=?= Date: Wed, 27 May 2020 01:47:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: gcov-profile X-Bugzilla-Version: 7.3.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dongjianqiang2 at huawei dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: marxin at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 01:47:22 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D95332 --- Comment #2 from John Dong --- (In reply to Martin Li=C5=A1ka from comment #1) > Hello. >=20 > I support the patch, do you have a copyright agreement and can you send t= he > patch to the GCC patches mailing list? >=20 > One small nit I noticed: > /home/marxin/Programming/gcc/gcc/../libgcc/libgcov-util.c: In function > =E2=80=98gcov_info* read_gcda_file(const char*)=E2=80=99: > /home/marxin/Programming/gcc/gcc/../libgcc/libgcov-util.c:264:12: warning: > unused variable =E2=80=98magic=E2=80=99 [-Wunused-variable] > 264 | unsigned magic, version; > | ^~~~~ Hi, thank you for your reply, I will the patch to the GCC patches mailing list. thanks.=