public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/95350] [coroutines] coroutines with move-only by-value parameters attempt to copy parameter instead of move it
Date: Fri, 12 Jun 2020 17:32:24 +0000	[thread overview]
Message-ID: <bug-95350-4-2EwJysTLmJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95350-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95350

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:284f809ef7fe8fa6b518c103d31e514a98f0f36e

commit r10-8285-g284f809ef7fe8fa6b518c103d31e514a98f0f36e
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Fri Jun 12 08:28:35 2020 +0100

    coroutines: Correct handling of references in parm copies [PR95350].

    Adjust to handle rvalue refs the same way as clang, and to correct
    the handling of moves when a copy CTOR is present.  This is one area
    where we could make things easier for the end-user (as was implemented
    before this change), however there needs to be agreement about when the
    full statement containing a coroutine call ends (i.e. when the ramp
    terminates or when the coroutine terminates).

    gcc/cp/ChangeLog:

            PR c++/95350
            * coroutines.cc (struct param_info): Remove rv_ref field.
            (build_actor_fn): Remove specifial rvalue ref handling.
            (morph_fn_to_coro): Likewise.

    gcc/testsuite/ChangeLog:

            PR c++/95350
            * g++.dg/coroutines/torture/func-params-08.C: Adjust test to
            reflect that all rvalue refs are dangling.
            * g++.dg/coroutines/torture/func-params-09-awaitable-parms.C:
            Likewise.
            * g++.dg/coroutines/pr95350.C: New test.

    (cherry picked from commit 88f48e2967ead9be262483618238efa9c7c842ec)

  parent reply	other threads:[~2020-06-12 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 21:19 [Bug c++/95350] New: " lewissbaker.opensource at gmail dot com
2020-05-27 19:41 ` [Bug c++/95350] " iains at gcc dot gnu.org
2020-06-01 19:25 ` cvs-commit at gcc dot gnu.org
2020-06-12 17:32 ` cvs-commit at gcc dot gnu.org [this message]
2020-06-12 17:54 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95350-4-2EwJysTLmJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).