[Bug fortran/95352] New: ICE on extra parenthesis

[Bug fortran/95352] New: ICE on extra parenthesis

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

            Bug ID: 95352
           Summary: ICE on extra parenthesis
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jrfsousa at gmail dot com
  Target Milestone: ---

Created attachment 48611
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48611&action=edit
Fortran code demonstrating problems.

Hi All!

An extra parenthesis generates an ICE with:

GNU Fortran (GCC) 10.1.1 20200525
GNU Fortran (GCC) 11.0.0 20200525 (experimental)

Thank you very much.

Best regards,
José Rui

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

--- Comment #1 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
On further investigation the ICE is not generated by the extra parenthesis, but
by the use of the lbound intrinsic.

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org
           Priority|P3                          |P4

--- Comment #2 from kargl at gcc dot gnu.org ---
(In reply to José Rui Faustino de Sousa from comment #1)
> On further investigation the ICE is not generated by the extra parenthesis,
> but by the use of the lbound intrinsic.

Index: gcc/fortran/simplify.c
===================================================================
--- gcc/fortran/simplify.c      (revision 280157)
+++ gcc/fortran/simplify.c      (working copy)
@@ -4019,7 +4023,7 @@ simplify_bound_dim (gfc_expr *array, gfc_expr *kind, i
       || (coarray && d == as->rank + as->corank
          && (!upper || flag_coarray == GFC_FCOARRAY_SINGLE)))
     {
-      if (as->lower[d-1]->expr_type == EXPR_CONSTANT)
+      if (as->lower[d-1] && as->lower[d-1]->expr_type == EXPR_CONSTANT)
        {
          gfc_free_expr (result);
          return gfc_copy_expr (as->lower[d-1]);

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-05-27
     Ever confirmed|0                           |1

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Started to ICE with r10-2912-g70570ec192745095.

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

--- Comment #4 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
I have tested the patch posted by Steve Kargl and it seems to do the trick.

Can I do anything to get this going?

Best regards,
José Rui

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

--- Comment #5 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Aug 20, 2020 at 11:15:27PM +0000, jrfsousa at gmail dot com wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352
> 
> --- Comment #4 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
> I have tested the patch posted by Steve Kargl and it seems to do the trick.
> 
> Can I do anything to get this going?
> 

I don't use git, so have way to move forward.  If
you want to package the patch and add the testcase,
I would appreciate it.

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

José Rui Faustino de Sousa <jrfsousa at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #6 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
Done!

https://gcc.gnu.org/pipermail/fortran/2020-August/054908.html

Thank you very much.

Best regards,
José Rui

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

--- Comment #7 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Fri, Aug 21, 2020 at 10:35:27AM +0000, jrfsousa at gmail dot com wrote:
> Done!
> 
> https://gcc.gnu.org/pipermail/fortran/2020-August/054908.html
> 
> Thank you very much.
> 

Thanks for submitting.  If no one reviews the patch in the
next day or so, I think you can commit it.

BTW, for the git log and ChangeLog, I use kargl@gcc.gnu.org
not my sgk@troutmask address.

[Bug fortran/95352] ICE on select rank with assumed-size selector and lbound intrinsic

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95352

José Rui Faustino de Sousa <jrfsousa at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
Fixed by:

https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=cd49b7067893b548a10c99ea0cb6aba2977eef2e