[Bug libstdc++/95392] New: Build failure on MinGW

[Bug libstdc++/95392] New: Build failure on MinGW

[markus.boeck02 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95392

            Bug ID: 95392
           Summary: Build failure on MinGW
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: markus.boeck02 at gmail dot com
  Target Milestone: ---

Current trunk version of GCC (tested with HEAD at
4833c1adc3c7b125bf1c59e8bd8d802ac3b0d205) fails to build using MinGW. The
compiler error is as follows:

In file included from
/mnt/c/GCC-Build/gcc/build/x86_64-w64-mingw32/libstdc++-v3/include/filesystem:45,
                 from ../../../../../libstdc++-v3/src/c++17/fs_ops.cc:32,
                 from ../../../../../libstdc++-v3/src/c++17/cow-fs_ops.cc:26:
/mnt/c/GCC-Build/gcc/build/x86_64-w64-mingw32/libstdc++-v3/include/bits/fs_path.h:
In function 'std::filesystem::path std::filesystem::u8path(const _Source&)':
/mnt/c/GCC-Build/gcc/build/x86_64-w64-mingw32/libstdc++-v3/include/bits/fs_path.h:789:32:
error: '_S_string_from_iter' is not a member of 'std::filesystem::path'
  789 |        std::string __s = path::_S_string_from_iter(__source);
      |      

The change that introduced the breakage is
584d52b088f9fcf78704b504c3f1f07e17c1cded. Reverting this commit makes the build
succeed

[Bug libstdc++/95392] [11 Regression] Build failure on MinGW

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95392

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
            Summary|Build failure on MinGW      |[11 Regression] Build
                   |                            |failure on MinGW
      Known to work|                            |10.1.0
   Last reconfirmed|                            |2020-05-28
      Known to fail|                            |11.0
           Keywords|                            |build
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Oops, I meant to check it on mingw-w64 before pushing that commit.

[Bug libstdc++/95392] [11 Regression] Build failure on MinGW

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95392

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug libstdc++/95392] [11 Regression] Build failure on MinGW

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95392

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:cd3f067b82a1331f5fb695879ba5c3d9bb2cca3a

commit r11-777-gcd3f067b82a1331f5fb695879ba5c3d9bb2cca3a
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jun 2 00:07:05 2020 +0100

    libstdc++: Fix filesystem::u8path for mingw targets (PR 95392)

    When I refactored filesystem::path string conversions in
    r11-587-584d52b088f9fcf78704b504c3f1f07e17c1cded I failed to update the
    mingw-specific code in filesystem::u8path, causing a bootstrap failure.

    This fixes it, and further refactors the mingw-specific code along the
    same lines as the previous commit. All conversions from UTF-8 strings to
    wide strings now use the same helper function, __wstr_from_utf8.

            PR libstdc++/95392
            * include/bits/fs_path.h (path::_S_to_string): Move to
            namespace-scope and rename to ...
            (__detail::__string_from_range): ... this.
            [WINDOWS] (__detail::__wstr_from_utf8): New function template to
            convert a char sequence containing UTF-8 to wstring.
            (path::_S_convert(Iter, Iter)): Adjust call to _S_to_string.
            (path::_S_convert_loc(Iter, Iter, const locale&)): Likewise.
            (u8path(InputIterator, InputIterator)) [WINDOWS]: Use
            __string_from_range to obtain a contiguous range and
            __wstr_from_utf8 to obtain a wide string.
            (u8path(const Source&)) [WINDOWS]: Use __effective_range to
            obtain a contiguous range and __wstr_from_utf8 to obtain a wide
            string.
            (path::_S_convert(const _EcharT*, const _EcharT)) [WINDOWS]:
            Use __wstr_from_utf8.

[Bug libstdc++/95392] [11 Regression] Build failure on MinGW

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95392

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|10.1.0                      |
         Resolution|---                         |FIXED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Should be fixed now, thanks for reporting it.